DevTools: migrate sidebar pane's titleElement to use Toolbar.

Source/devtools/front_end/ui/Toolbar.js

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 13 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 /**
  * @constructor
  * @param {!Element=} parentElement
+ * @param {boolean=} withBorder
  */
-WebInspector.Toolbar = function(parentElement)
+WebInspector.Toolbar = function(parentElement, withBorder)
 {
     /** @type {!Array.<!WebInspector.ToolbarItem>} */
     this._items = [];
     this.element = parentElement ? parentElement.createChild("div", "toolbar") : createElementWithClass("div", "toolbar");
-
     this._shadowRoot = WebInspector.createShadowRootWithCoreStyles(this.element);
     this._shadowRoot.appendChild(WebInspector.Widget.createStyleElement("ui/toolbar.css"));
     this._contentElement = this._shadowRoot.createChild("div", "toolbar-shadow");
     this._contentElement.createChild("content");
+    if (withBorder)

[dgozman, 2015/06/09 13:27:02]

Drop this one.

[pfeldman, 2015/06/09 13:40:59]

Done.

+        this._contentElement.classList.add("with-border");
 }
 
 WebInspector.Toolbar.prototype = {
     makeNarrow: function()
     {
         this._contentElement.classList.add("narrow");
     },
 
     makeVertical: function()
     {
@@ skipping 476 matching lines @@
         function mouseUp(e)
         {
             if (e.which !== 1)
                 return;
             optionsGlassPane.dispose();
             document.documentElement.removeEventListener("mouseup", mouseUp, false);
 
             for (var i = 0; i < buttons.length; ++i) {
                 if (buttons[i].element.classList.contains("emulate-active")) {
                     buttons[i].element.classList.remove("emulate-active");
-                    buttons[i]._clicked();
+                    buttons[i]._clicked(e);
                     break;
                 }
             }
         }
     },
 
     __proto__: WebInspector.ToolbarItem.prototype
 }
 
 /**
@@ skipping 366 matching lines @@
     },
 
     __proto__: WebInspector.ToolbarButton.prototype
 }
 
 /**
  * @constructor
  * @extends {WebInspector.Toolbar}
  * @param {string} location
  * @param {!Element=} parentElement
+ * @param {boolean=} withBorder
  */
-WebInspector.ExtensibleToolbar = function(location, parentElement)
+WebInspector.ExtensibleToolbar = function(location, parentElement, withBorder)
 {
-    WebInspector.Toolbar.call(this, parentElement);
+    WebInspector.Toolbar.call(this, parentElement, withBorder);
     this._loadItems(location);
 }
 
 WebInspector.ExtensibleToolbar.prototype = {
     /**
      * @param {string} location
      */
     _loadItems: function(location)
     {
         var extensions = self.runtime.extensions(WebInspector.ToolbarItem.Provider);
@@ skipping 49 matching lines @@
             for (var i = 0; i < items.length; ++i) {
                 var item = items[i];
                 if (item)
                     this.appendToolbarItem(item);
             }
         }
     },
 
     __proto__: WebInspector.Toolbar.prototype
 }