Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Side by Side Diff: Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js

Issue 1172643002: DevTools: migrate sidebar pane's titleElement to use Toolbar. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: only using latin1 in css Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @constructor 6 * @constructor
7 * @extends {WebInspector.BreakpointsSidebarPaneBase} 7 * @extends {WebInspector.BreakpointsSidebarPaneBase}
8 * @implements {WebInspector.TargetManager.Observer} 8 * @implements {WebInspector.TargetManager.Observer}
9 */ 9 */
10 WebInspector.XHRBreakpointsSidebarPane = function() 10 WebInspector.XHRBreakpointsSidebarPane = function()
11 { 11 {
12 WebInspector.BreakpointsSidebarPaneBase.call(this, WebInspector.UIString("XH R Breakpoints")); 12 WebInspector.BreakpointsSidebarPaneBase.call(this, WebInspector.UIString("XH R Breakpoints"));
13 this._xhrBreakpointsSetting = WebInspector.settings.createLocalSetting("xhrB reakpoints", []); 13 this._xhrBreakpointsSetting = WebInspector.settings.createLocalSetting("xhrB reakpoints", []);
14 14
15 /** @type {!Map.<string, !Element>} */ 15 /** @type {!Map.<string, !Element>} */
16 this._breakpointElements = new Map(); 16 this._breakpointElements = new Map();
17 17
18 var addButton = this.titleElement.createChild("button", "pane-title-button a dd"); 18 var addButton = new WebInspector.ToolbarButton(WebInspector.UIString("Add br eakpoint"), "add-toolbar-item");
19 addButton.title = WebInspector.UIString("Add XHR breakpoint"); 19 addButton.addEventListener("click", this._addButtonClicked.bind(this));
20 addButton.addEventListener("click", this._addButtonClicked.bind(this), false ); 20 this.toolbar().appendToolbarItem(addButton);
21 21
22 this.emptyElement.addEventListener("contextmenu", this._emptyElementContextM enu.bind(this), true); 22 this.emptyElement.addEventListener("contextmenu", this._emptyElementContextM enu.bind(this), true);
23 23
24 WebInspector.targetManager.observeTargets(this); 24 WebInspector.targetManager.observeTargets(this);
25 } 25 }
26 26
27 WebInspector.XHRBreakpointsSidebarPane.prototype = { 27 WebInspector.XHRBreakpointsSidebarPane.prototype = {
28 /** 28 /**
29 * @override 29 * @override
30 * @param {!WebInspector.Target} target 30 * @param {!WebInspector.Target} target
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 92
93 if (this._breakpointElements.has(url)) 93 if (this._breakpointElements.has(url))
94 return; 94 return;
95 95
96 var element = createElement("li"); 96 var element = createElement("li");
97 element._url = url; 97 element._url = url;
98 element.addEventListener("contextmenu", this._contextMenu.bind(this, url ), true); 98 element.addEventListener("contextmenu", this._contextMenu.bind(this, url ), true);
99 99
100 var title = url ? WebInspector.UIString("URL contains \"%s\"", url) : We bInspector.UIString("Any XHR"); 100 var title = url ? WebInspector.UIString("URL contains \"%s\"", url) : We bInspector.UIString("Any XHR");
101 var label = createCheckboxLabel(title, enabled); 101 var label = createCheckboxLabel(title, enabled);
102 label.classList.add("checkbox-elem");
103 element.appendChild(label); 102 element.appendChild(label);
104 label.checkboxElement.addEventListener("click", this._checkboxClicked.bi nd(this, url), false); 103 label.checkboxElement.addEventListener("click", this._checkboxClicked.bi nd(this, url), false);
105 element._checkboxElement = label.checkboxElement; 104 element._checkboxElement = label.checkboxElement;
106 105
107 label.textElement.classList.add("cursor-auto"); 106 label.textElement.classList.add("cursor-auto");
108 label.textElement.addEventListener("dblclick", this._labelClicked.bind(t his, url), false); 107 label.textElement.addEventListener("dblclick", this._labelClicked.bind(t his, url), false);
109 108
110 var currentElement = /** @type {?Element} */ (this.listElement.firstChil d); 109 var currentElement = /** @type {?Element} */ (this.listElement.firstChil d);
111 while (currentElement) { 110 while (currentElement) {
112 if (currentElement._url && currentElement._url < element._url) 111 if (currentElement._url && currentElement._url < element._url)
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
247 var breakpoints = this._xhrBreakpointsSetting.get(); 246 var breakpoints = this._xhrBreakpointsSetting.get();
248 for (var i = 0; i < breakpoints.length; ++i) { 247 for (var i = 0; i < breakpoints.length; ++i) {
249 var breakpoint = breakpoints[i]; 248 var breakpoint = breakpoints[i];
250 if (breakpoint && typeof breakpoint.url === "string") 249 if (breakpoint && typeof breakpoint.url === "string")
251 this._setBreakpoint(breakpoint.url, breakpoint.enabled, target); 250 this._setBreakpoint(breakpoint.url, breakpoint.enabled, target);
252 } 251 }
253 }, 252 },
254 253
255 __proto__: WebInspector.BreakpointsSidebarPaneBase.prototype 254 __proto__: WebInspector.BreakpointsSidebarPaneBase.prototype
256 } 255 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698