Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1172643002: DevTools: migrate sidebar pane's titleElement to use Toolbar. (Closed)

Created:
5 years, 6 months ago by pfeldman
Modified:
5 years, 6 months ago
Reviewers:
dgozman
CC:
blink-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, aboxhall, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, nektarios, dmazzoni, apavlov+blink_chromium.org, devtools-reviews_chromium.org, je_julie, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: migrate sidebar pane's titleElement to use Toolbar. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196782

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebaselined #

Total comments: 15

Patch Set 4 : rebaselined #

Patch Set 5 : #

Patch Set 6 : only using latin1 in css #

Unified diffs Side-by-side diffs Delta from patch set Stats (+384 lines, -527 lines) Patch
M LayoutTests/http/tests/inspector/elements-test.js View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/inspector/audits/audits-panel-functional-expected.txt View 1 chunk +44 lines, -44 lines 0 comments Download
M LayoutTests/inspector/audits/audits-panel-noimages-functional-expected.txt View 1 chunk +28 lines, -28 lines 0 comments Download
M LayoutTests/inspector/elements/event-listener-sidebar.html View 2 chunks +2 lines, -4 lines 0 comments Download
M LayoutTests/inspector/elements/event-listener-sidebar-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/event-listeners-about-blank.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/extensions/extensions-audits-content-script-expected.txt View 1 chunk +40 lines, -40 lines 0 comments Download
M LayoutTests/inspector/extensions/extensions-audits-expected.txt View 1 chunk +37 lines, -37 lines 0 comments Download
M LayoutTests/inspector/extensions/extensions-sidebar.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/sources/debugger-ui/error-in-watch-expressions.html View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/accessibility/AccessibilitySidebarView.js View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/audits/AuditResultView.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/audits/auditsPanel.css View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/devtools/front_end/components/BreakpointsSidebarPaneBase.js View 5 chunks +8 lines, -7 lines 0 comments Download
M Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js View 3 chunks +3 lines, -11 lines 0 comments Download
M Source/devtools/front_end/components/breakpointsList.css View 1 2 3 4 5 chunks +3 lines, -20 lines 0 comments Download
M Source/devtools/front_end/components/eventListenersView.css View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/devtools/front_end/elements/ElementStatePaneWidget.js View 1 2 3 4 2 chunks +4 lines, -3 lines 0 comments Download
M Source/devtools/front_end/elements/ElementsPanel.js View 4 chunks +7 lines, -8 lines 0 comments Download
M Source/devtools/front_end/elements/ElementsSidebarView.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/elements/EventListenersWidget.js View 4 chunks +9 lines, -37 lines 0 comments Download
M Source/devtools/front_end/elements/MetricsSidebarPane.js View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/elements/StylesSidebarPane.js View 1 2 3 4 chunks +13 lines, -8 lines 0 comments Download
M Source/devtools/front_end/elements/elementsPanel.css View 1 2 3 11 chunks +28 lines, -61 lines 0 comments Download
M Source/devtools/front_end/extensions/ExtensionPanel.js View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/devtools/front_end/inspectorStyle.css View 2 chunks +1 line, -5 lines 0 comments Download
M Source/devtools/front_end/network/networkPanel.css View 2 chunks +2 lines, -10 lines 0 comments Download
M Source/devtools/front_end/network/requestCookiesView.css View 1 chunk +1 line, -5 lines 0 comments Download
M Source/devtools/front_end/profiler/profilesPanel.css View 1 chunk +1 line, -5 lines 0 comments Download
M Source/devtools/front_end/resources/resourcesPanel.css View 1 chunk +1 line, -5 lines 0 comments Download
M Source/devtools/front_end/sidebarPane.css View 1 2 3 5 chunks +22 lines, -73 lines 0 comments Download
M Source/devtools/front_end/sources/AsyncOperationsSidebarPane.js View 4 chunks +7 lines, -8 lines 0 comments Download
M Source/devtools/front_end/sources/CallStackSidebarPane.js View 1 2 4 chunks +8 lines, -11 lines 0 comments Download
M Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js View 1 2 3 4 5 chunks +9 lines, -12 lines 0 comments Download
M Source/devtools/front_end/sources/ObjectEventListenersSidebarPane.js View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/devtools/front_end/sources/ScopeChainSidebarPane.js View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sources/ServiceWorkersSidebarPane.js View 2 chunks +4 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sources/SourcesPanel.js View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M Source/devtools/front_end/sources/ThreadsSidebarPane.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js View 1 2 3 4 5 chunks +16 lines, -17 lines 0 comments Download
M Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js View 2 chunks +3 lines, -4 lines 0 comments Download
M Source/devtools/front_end/sources/serviceWorkersSidebar.css View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/devtools/front_end/sources/sourcesPanel.css View 2 chunks +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sources/uiList.css View 1 2 3 4 5 2 chunks +14 lines, -6 lines 0 comments Download
M Source/devtools/front_end/ui/SidebarPane.js View 1 2 3 5 chunks +17 lines, -4 lines 0 comments Download
M Source/devtools/front_end/ui/Toolbar.js View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M Source/devtools/front_end/ui/Widget.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/ui/toolbar.css View 1 2 3 4 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
pfeldman
5 years, 6 months ago (2015-06-09 12:33:23 UTC) #2
dgozman
https://codereview.chromium.org/1172643002/diff/40001/Source/devtools/front_end/components/breakpointsList.css File Source/devtools/front_end/components/breakpointsList.css (right): https://codereview.chromium.org/1172643002/diff/40001/Source/devtools/front_end/components/breakpointsList.css#newcode74 Source/devtools/front_end/components/breakpointsList.css:74: .breakpoint-list .checkbox-elem { nit: empty rule https://codereview.chromium.org/1172643002/diff/40001/Source/devtools/front_end/elements/ElementStatePaneWidget.js File Source/devtools/front_end/elements/ElementStatePaneWidget.js ...
5 years, 6 months ago (2015-06-09 13:27:02 UTC) #3
pfeldman
https://codereview.chromium.org/1172643002/diff/40001/Source/devtools/front_end/components/breakpointsList.css File Source/devtools/front_end/components/breakpointsList.css (right): https://codereview.chromium.org/1172643002/diff/40001/Source/devtools/front_end/components/breakpointsList.css#newcode74 Source/devtools/front_end/components/breakpointsList.css:74: .breakpoint-list .checkbox-elem { On 2015/06/09 13:27:02, dgozman wrote: > ...
5 years, 6 months ago (2015-06-09 13:40:59 UTC) #4
dgozman
lgtm
5 years, 6 months ago (2015-06-09 13:43:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1172643002/80001
5 years, 6 months ago (2015-06-09 13:53:30 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/46937) mac_blink_rel on tryserver.blink (JOB_FAILED, ...
5 years, 6 months ago (2015-06-09 14:01:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1172643002/100001
5 years, 6 months ago (2015-06-09 15:35:44 UTC) #12
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 16:46:24 UTC) #13
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196782

Powered by Google App Engine
This is Rietveld 408576698