Prevent ONC-pushed certificates from being used with multiprofiles.

chrome/browser/chromeos/login/multi_profile_user_controller_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/multi_profile_user_controller.h"
 
 #include "base/memory/scoped_ptr.h"
+#include "base/run_loop.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/chromeos/login/fake_user_manager.h"
 #include "chrome/browser/chromeos/login/multi_profile_user_controller_delegate.h"
 #include "chrome/browser/chromeos/login/user_manager.h"
+#include "chrome/browser/chromeos/policy/policy_cert_service.h"
+#include "chrome/browser/chromeos/policy/policy_cert_service_factory.h"
+#include "chrome/browser/chromeos/policy/policy_cert_verifier.h"
 #include "chrome/browser/prefs/browser_prefs.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/test/base/scoped_testing_local_state.h"
 #include "chrome/test/base/testing_browser_process.h"
 #include "chrome/test/base/testing_pref_service_syncable.h"
 #include "chrome/test/base/testing_profile.h"
 #include "chrome/test/base/testing_profile_manager.h"
+#include "content/public/test/test_browser_thread_bundle.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace chromeos {
 
 namespace {
 
 const char* kUsers[] = {"a@gmail.com", "b@gmail.com" };
 
 struct BehaviorTestCase {
   const char* primary;
@@ skipping 42 matching lines @@
     MultiProfileUserController::kBehaviorPrimaryOnly,
     false,
   },
   {
     MultiProfileUserController::kBehaviorNotAllowed,
     MultiProfileUserController::kBehaviorNotAllowed,
     false,
   },
 };
 
+policy::PolicyCertVerifier* g_policy_cert_verifier_for_factory = NULL;
+
+BrowserContextKeyedService* TestPolicyCertServiceFactory(
+    content::BrowserContext* context) {
+  return policy::PolicyCertService::CreateForTesting(
+      kUsers[0], g_policy_cert_verifier_for_factory).release();
+}
+
 }  // namespace
 
 class MultiProfileUserControllerTest
     : public testing::Test,
       public MultiProfileUserControllerDelegate {
  public:
   MultiProfileUserControllerTest()
       : profile_manager_(TestingBrowserProcess::GetGlobal()),
         fake_user_manager_(new FakeUserManager),
         user_manager_enabler_(fake_user_manager_),
         user_not_allowed_count_(0) {}
   virtual ~MultiProfileUserControllerTest() {}
 
   virtual void SetUp() OVERRIDE {
     ASSERT_TRUE(profile_manager_.SetUp());
     controller_.reset(new MultiProfileUserController(
         this, TestingBrowserProcess::GetGlobal()->local_state()));
 
     for (size_t i = 0; i < arraysize(kUsers); ++i) {
       const std::string user_email(kUsers[i]);
-      fake_user_manager_->AddUser(user_email);
+      const User* user = fake_user_manager_->AddUser(user_email);
 
       // Note that user profiles are created after user login in reality.
       TestingProfile* user_profile =
           profile_manager_.CreateTestingProfile(user_email);
       user_profile->set_profile_name(user_email);
       user_profiles_.push_back(user_profile);
+
+      fake_user_manager_->SetProfileForUser(user, user_profile);
     }
   }
 
   void LoginUser(size_t user_index) {
     ASSERT_LT(user_index, arraysize(kUsers));
     fake_user_manager_->LoginUser(kUsers[user_index]);
     controller_->StartObserving(user_profiles_[user_index]);
   }
 
   void SetOwner(size_t user_index) {
@@ skipping 23 matching lines @@
   }
 
   // MultiProfileUserControllerDeleagte overrides:
   virtual void OnUserNotAllowed() OVERRIDE {
     ++user_not_allowed_count_;
   }
 
   MultiProfileUserController* controller() { return controller_.get(); }
   int user_not_allowed_count() const { return user_not_allowed_count_; }
 
+  TestingProfile* profile(int index) {
+    return user_profiles_[index];
+  }
+
  private:
+  content::TestBrowserThreadBundle threads_;
   TestingProfileManager profile_manager_;
   FakeUserManager* fake_user_manager_;  // Not owned
   ScopedUserManagerEnabler user_manager_enabler_;
 
   scoped_ptr<MultiProfileUserController> controller_;
 
   std::vector<TestingProfile*> user_profiles_;
 
   int user_not_allowed_count_;
 
@@ skipping 94 matching lines @@
   LoginUser(0);
   SetOwner(1);
 
   EXPECT_FALSE(controller()->IsUserAllowedInSession(kUsers[1]));
 
   EXPECT_EQ(0, user_not_allowed_count());
   LoginUser(1);
   EXPECT_EQ(1, user_not_allowed_count());
 }
 
+TEST_F(MultiProfileUserControllerTest,
+       UsedPolicyCertificatesAllowedForPrimary) {
+  // Verifies that any user can sign-in as the primary user, regardless of the
+  // tainted state.
+  policy::PolicyCertServiceFactory::SetUsedPolicyCertificates(kUsers[0]);
+  EXPECT_TRUE(controller()->IsUserAllowedInSession(kUsers[0]));
+  EXPECT_TRUE(controller()->IsUserAllowedInSession(kUsers[1]));
+}
+
+TEST_F(MultiProfileUserControllerTest,
+       UsedPolicyCertificatesDisallowedForSecondary) {
+  // Verifies that if a regular user is signed-in then other regular users can
+  // be added but tainted users can't.
+  LoginUser(1);
+  EXPECT_TRUE(controller()->IsUserAllowedInSession(kUsers[0]));
+  policy::PolicyCertServiceFactory::SetUsedPolicyCertificates(kUsers[0]);
+  EXPECT_FALSE(controller()->IsUserAllowedInSession(kUsers[0]));
+}
+
+TEST_F(MultiProfileUserControllerTest,
+       UsedPolicyCertificatesDisallowsSecondaries) {

[pneubeck (no reviews), 2013/12/18 09:11:07]

since this is about testing the UserController, the alternative would be to mock
the PolicyCertService (which in turn requires adding a pure interface).

[Joao da Silva, 2013/12/18 09:40:13]

Right. We may do that cleanup if more tests require a mocked PolicyCertService,
but the CreateForTesting() call works for now.

+  // Verifies that if a tainted user is signed-in then no other users can
+  // be added.
+  policy::PolicyCertServiceFactory::SetUsedPolicyCertificates(kUsers[0]);
+  LoginUser(0);
+
+  // Double parenthesis to avoid http://en.wikipedia.org/wiki/Most_vexing_parse.
+  policy::PolicyCertVerifier verifier((base::Closure()));
+  g_policy_cert_verifier_for_factory = &verifier;
+  ASSERT_TRUE(
+      policy::PolicyCertServiceFactory::GetInstance()->SetTestingFactoryAndUse(
+          profile(0), TestPolicyCertServiceFactory));
+
+  EXPECT_FALSE(controller()->IsUserAllowedInSession(kUsers[1]));
+  policy::PolicyCertServiceFactory::SetUsedPolicyCertificates(kUsers[1]);
+  EXPECT_FALSE(controller()->IsUserAllowedInSession(kUsers[1]));
+
+  // Flush tasks posted to IO.
+  base::RunLoop().RunUntilIdle();
+}
+
 }  // namespace chromeos