Prevent ONC-pushed certificates from being used with multiprofiles.

chrome/browser/ui/ash/chrome_shell_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/ash/chrome_shell_delegate.h"
 
 #include "apps/shell_window.h"
 #include "apps/shell_window_registry.h"
 #include "ash/host/root_window_host_factory.h"
 #include "ash/magnifier/magnifier_constants.h"
 #include "ash/wm/window_state.h"
 #include "ash/wm/window_util.h"
 #include "base/command_line.h"
 #include "chrome/browser/app_mode/app_mode_utils.h"
 #include "chrome/browser/lifetime/application_lifetime.h"
+#include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/ui/app_list/app_list_service.h"
 #include "chrome/browser/ui/app_list/app_list_view_delegate.h"
 #include "chrome/browser/ui/ash/app_list/app_list_controller_ash.h"
 #include "chrome/browser/ui/ash/ash_keyboard_controller_proxy.h"
 #include "chrome/browser/ui/ash/launcher/chrome_launcher_controller.h"
 #include "chrome/browser/ui/ash/launcher/launcher_context_menu.h"
 #include "chrome/browser/ui/ash/user_action_handler.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/common/chrome_switches.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 
 #if defined(OS_CHROMEOS)
 #include "chrome/browser/chromeos/accessibility/accessibility_manager.h"
+#include "chrome/browser/chromeos/login/user.h"
 #include "chrome/browser/chromeos/login/user_manager.h"
+#include "chrome/browser/chromeos/policy/policy_cert_service.h"
+#include "chrome/browser/chromeos/policy/policy_cert_service_factory.h"
 #endif
 
 // static
 ChromeShellDelegate* ChromeShellDelegate::instance_ = NULL;
 
 ChromeShellDelegate::ChromeShellDelegate()
     : shelf_delegate_(NULL) {
   instance_ = this;
   PlatformInit();
 }
@@ skipping 24 matching lines @@
     // in. For special cases like Kiosk mode and / or guest mode this isn't a
     // problem since either the browser gets restarted and / or the flag is not
     // allowed, but for an "ephermal" user (see crbug.com/312324) it is not
     // decided yet if he could add other users to his session or not.
     // TODO(skuhne): As soon as the issue above needs to be resolved, this logic
     // should change.
     logged_in_users = 1;
   }
   if (admitted_users_to_be_added + logged_in_users <= 1)
     return false;
+
+  chromeos::User* active = chromeos::UserManager::Get()->GetActiveUser();
+  Profile* profile = NULL;
+  policy::PolicyCertService* service = NULL;
+  if (active)

[pneubeck (no reviews), 2013/12/17 15:25:31]

are !active
and !profile
errors? DCHECK/LOG?

[Joao da Silva, 2013/12/17 16:36:41]

!active means that no-one is signed in yet, so it's fine.

active && !profile should not happen; GetProfileByUser triggers a DCHECK (at
ProfileManager) if that happens.

+    profile = chromeos::UserManager::Get()->GetProfileByUser(active);
+  if (profile)
+    service = policy::PolicyCertServiceFactory::GetForProfile(profile);
+  if (service && service->IsTainted()) {
+    LOG(ERROR) << "Disabling multi-profiles because the current Profile is "
+               << "exposed to policy-pushed certificates.";
+    return false;
+  }
 #endif
   return true;
 }
 
 bool ChromeShellDelegate::IsIncognitoAllowed() const {
 #if defined(OS_CHROMEOS)
   return chromeos::AccessibilityManager::Get()->IsIncognitoAllowed();
 #endif
   return true;
 }
@@ skipping 55 matching lines @@
 }
 
 base::string16 ChromeShellDelegate::GetProductName() const {
   return l10n_util::GetStringUTF16(IDS_PRODUCT_NAME);
 }
 
 keyboard::KeyboardControllerProxy*
     ChromeShellDelegate::CreateKeyboardControllerProxy() {
   return new AshKeyboardControllerProxy();
 }