 Chromium Code Reviews
 Chromium Code Reviews Issue 1172603002:
  Oilpan: Disabling lazy sweeping shouldn't deactivate EAGERLY_FINALIZE.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/blink.git@master
    
  
    Issue 1172603002:
  Oilpan: Disabling lazy sweeping shouldn't deactivate EAGERLY_FINALIZE.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/blink.git@master| Index: Source/platform/heap/Heap.h | 
| diff --git a/Source/platform/heap/Heap.h b/Source/platform/heap/Heap.h | 
| index a3654f54af933d5b94bf37a3483736d0b7b4311e..1c4456ad526654b1ddfcde8578d455c590adacfc 100644 | 
| --- a/Source/platform/heap/Heap.h | 
| +++ b/Source/platform/heap/Heap.h | 
| @@ -1181,7 +1181,6 @@ inline bool Heap::isNormalHeapIndex(int index) | 
| return index >= NormalPage1HeapIndex && index <= NormalPage4HeapIndex; | 
| } | 
| -#if ENABLE(LAZY_SWEEPING) | 
| #define DECLARE_EAGER_FINALIZATION_OPERATOR_NEW() \ | 
| public: \ | 
| GC_PLUGIN_IGNORE("491488") \ | 
| @@ -1214,13 +1213,6 @@ public: \ | 
| #else | 
| #define EAGERLY_FINALIZE() typedef int IsEagerlyFinalizedMarker | 
| #endif | 
| -#else | 
| -#define DECLARE_EAGER_FINALIZATION_OPERATOR_NEW() | 
| -#define EAGERLY_FINALIZE() | 
| -// TODO(Oilpan): define in terms of Oilpan's EAGERLY_FINALIZE() once lazy | 
| -// sweeping is enabled non-Oilpan. | 
| -#define EAGERLY_FINALIZE_WILL_BE_REMOVED() | 
| 
sof
2015/06/09 13:58:51
This strikes me as wrong; we need to eagerly final
 
sof
2015/06/09 14:48:10
I think the analysis from 
 https://groups.google
 | 
| -#endif | 
| NO_SANITIZE_ADDRESS inline | 
| size_t HeapObjectHeader::size() const |