chrome/browser/extensions/extension_process_manager.h - Issue 11726002: Move the parsing of 'update_url' & 'options_page' URLs out of Extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_process_manager.h

Issue 11726002: Move the parsing of 'update_url' & 'options_page' URLs out of Extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@url_parse

Patch Set: fixed HomepageURLManifestTest.GetHomepageURL Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_context_menu_model.cc ('k') | chrome/browser/extensions/extension_process_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_process_manager.h

diff --git a/chrome/browser/extensions/extension_process_manager.h b/chrome/browser/extensions/extension_process_manager.h

index efd915e80d182e1344452157257846ad2f11e736..7d5d39ceb4289b298284c0e4cc1d71769320dca9 100644

--- a/chrome/browser/extensions/extension_process_manager.h

+++ b/chrome/browser/extensions/extension_process_manager.h

@@ -74,6 +74,8 @@ class ExtensionProcessManager : public content::NotificationObserver {

Browser* browser);

// Open the extension's options page.

+ // TODO(yoz): Move this function to a more appropriate location.

+ // crbug.com/157279

void OpenOptionsPage(const extensions::Extension* extension,

Browser* browser);