chrome/browser/extensions/extension_service.cc - Issue 11726002: Move the parsing of 'update_url' & 'options_page' URLs out of Extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 11726002: Move the parsing of 'update_url' & 'options_page' URLs out of Extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@url_parse

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_process_manager.cc ('K') | « chrome/browser/extensions/extension_process_manager.cc ('k') | chrome/browser/extensions/extension_service_unittest.cc » ('j') | chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_service.cc

diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc

index b89c7abd0f4de03548ac29d06478f88b2372b85f..b3e4f66590eee19f453264a6330c79b230ad62af 100644

--- a/chrome/browser/extensions/extension_service.cc

+++ b/chrome/browser/extensions/extension_service.cc

@@ -89,6 +89,7 @@

#include "chrome/common/extensions/feature_switch.h"

#include "chrome/common/extensions/features/feature.h"

#include "chrome/common/extensions/manifest.h"

+#include "chrome/common/extensions/manifest_url_info.h"

#include "chrome/common/pref_names.h"

#include "chrome/common/url_constants.h"

#include "content/public/browser/browser_thread.h"

@@ -128,6 +129,7 @@ using extensions::Extension;

using extensions::ExtensionIdSet;

using extensions::ExtensionInfo;

using extensions::FeatureSwitch;

+using extensions::ManifestURLInfo;

using extensions::PermissionMessage;

using extensions::PermissionMessages;

using extensions::PermissionSet;

@@ -2352,7 +2354,8 @@ void ExtensionService::OnExtensionInstalled(

LOG(WARNING) << "ShouldAllowInstall() returned false for "

<< id << " of type " << extension->GetType()

- << " and update URL " << extension->update_url().spec()

+ << " and update URL "

+ << ManifestURLInfo::GetUpdateURL(extension).spec()

<< "; not installing";

content::NotificationService::current()->Notify(