Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1329)

Unified Diff: chrome/browser/extensions/api/management/management_api.cc

Issue 11726002: Move the parsing of 'update_url' & 'options_page' URLs out of Extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@url_parse
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/management/management_api.cc
diff --git a/chrome/browser/extensions/api/management/management_api.cc b/chrome/browser/extensions/api/management/management_api.cc
index dadd49100f63dbf0214943ad6c1330d772fbf866..1d95bb3120e2eff66d0f6d537d1d765c9696d932 100644
--- a/chrome/browser/extensions/api/management/management_api.cc
+++ b/chrome/browser/extensions/api/management/management_api.cc
@@ -98,7 +98,7 @@ scoped_ptr<management::ExtensionInfo> CreateExtensionInfo(
info->offline_enabled = extension.offline_enabled();
info->version = extension.VersionString();
info->description = extension.description();
- info->options_url = extension.options_url().spec();
+ info->options_url = ManifestURLInfo::GetOptionsPage(&extension).spec();
info->homepage_url.reset(
new std::string(ManifestURLInfo::GetHomepageURL(&extension).spec()));
info->may_disable = system->management_policy()->
@@ -130,9 +130,9 @@ scoped_ptr<management::ExtensionInfo> CreateExtensionInfo(
}
}
- if (!extension.update_url().is_empty()) {
+ if (!ManifestURLInfo::GetUpdateURL(&extension).is_empty()) {
info->update_url.reset(new std::string(
- extension.update_url().spec()));
+ ManifestURLInfo::GetUpdateURL(&extension).spec()));
}
if (extension.is_app()) {

Powered by Google App Engine
This is Rietveld 408576698