chrome/browser/themes/theme_syncable_service.cc - Issue 11726002: Move the parsing of 'update_url' & 'options_page' URLs out of Extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/themes/theme_syncable_service.cc

Issue 11726002: Move the parsing of 'update_url' & 'options_page' URLs out of Extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@url_parse

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_process_manager.cc ('K') | « chrome/browser/extensions/updater/extension_downloader.cc ('k') | chrome/browser/themes/theme_syncable_service_unittest.cc » ('j') | chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/themes/theme_syncable_service.cc

diff --git a/chrome/browser/themes/theme_syncable_service.cc b/chrome/browser/themes/theme_syncable_service.cc

index 56fc5ffcc03084dc973a926855b8655c9d18ade8..5c6b9481b32c75b41b818c136aaa54a7ce344ab1 100644

--- a/chrome/browser/themes/theme_syncable_service.cc

+++ b/chrome/browser/themes/theme_syncable_service.cc

@@ -10,6 +10,7 @@

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/themes/theme_service.h"

#include "chrome/common/extensions/extension.h"

+#include "chrome/common/extensions/manifest_url_info.h"

#include "sync/protocol/sync.pb.h"

#include "sync/protocol/theme_specifics.pb.h"

@@ -268,7 +269,7 @@ void ThemeSyncableService::GetThemeSpecificsFromCurrentTheme(

theme_specifics->set_custom_theme_name(current_theme->name());

theme_specifics->set_custom_theme_id(current_theme->id());

theme_specifics->set_custom_theme_update_url(

- current_theme->update_url().spec());

+ extensions::ManifestURLInfo::GetUpdateURL(current_theme).spec());

} else {

DCHECK(!current_theme);

theme_specifics->clear_custom_theme_name();