chrome/browser/extensions/manifest_url_parser.cc - Issue 11726002: Move the parsing of 'update_url' & 'options_page' URLs out of Extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/manifest_url_parser.cc

Issue 11726002: Move the parsing of 'update_url' & 'options_page' URLs out of Extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@url_parse

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_process_manager.cc ('K') | « chrome/browser/extensions/extension_sync_data.cc ('k') | chrome/browser/extensions/updater/extension_downloader.cc » ('j') | chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/manifest_url_parser.cc

diff --git a/chrome/browser/extensions/manifest_url_parser.cc b/chrome/browser/extensions/manifest_url_parser.cc

index 6bbc7b0bf6bd583c1199244f806b0f914d8c2d9d..be0d5a861f2aa70faea80523fb70ef69bb49fb7d 100644

--- a/chrome/browser/extensions/manifest_url_parser.cc

+++ b/chrome/browser/extensions/manifest_url_parser.cc

@@ -10,6 +10,8 @@

#include "chrome/common/extensions/extension_manifest_constants.h"

#include "chrome/common/extensions/homepage_url_handler.h"

#include "chrome/common/extensions/manifest_handler.h"

+#include "chrome/common/extensions/options_page_handler.h"

+#include "chrome/common/extensions/update_url_handler.h"

namespace extensions {

@@ -18,6 +20,10 @@ ManifestURLParser::ManifestURLParser(Profile* profile) {

new DevToolsPageHandler);

ManifestHandler::Register(extension_manifest_keys::kHomepageURL,

new HomepageURLHandler);

+ ManifestHandler::Register(extension_manifest_keys::kUpdateURL,

+ new UpdateURLHandler);

+ ManifestHandler::Register(extension_manifest_keys::kOptionsPage,

+ new OptionsPageHandler);

}

ManifestURLParser::~ManifestURLParser() {