Move the parsing of 'update_url' & 'options_page' URLs out of Extension.

chrome/common/extensions/update_url_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "chrome/common/extensions/homepage_url_handler.h"
+#include "chrome/common/extensions/update_url_handler.h"
 
 #include "base/memory/scoped_ptr.h"
+#include "base/utf_string_conversions.h"
 #include "base/values.h"
 #include "chrome/common/extensions/extension_manifest_constants.h"
 #include "chrome/common/extensions/manifest_url_info.h"
 #include "extensions/common/error_utils.h"
 
 namespace keys = extension_manifest_keys;
 namespace errors = extension_manifest_errors;
 
 namespace extensions {
 
-HomepageURLHandler::HomepageURLHandler() {
+UpdateURLHandler::UpdateURLHandler() {
 }
 
-HomepageURLHandler::~HomepageURLHandler() {
+UpdateURLHandler::~UpdateURLHandler() {
 }
 
-bool HomepageURLHandler::Parse(const base::Value* value,
-                               Extension* extension,
-                               string16* error) {
+bool UpdateURLHandler::Parse(const base::Value* value,
+                             Extension* extension,
+                             string16* error) {
   scoped_ptr<ManifestURLInfo> info(new ManifestURLInfo);
-  std::string homepage_url_str;
-  if (!value->GetAsString(&homepage_url_str)) {
+  std::string tmp_update_url;
+
+  if (!value->GetAsString(&tmp_update_url)) {
     *error = ErrorUtils::FormatErrorMessageUTF16(
-        errors::kInvalidHomepageURL, "");
+        errors::kInvalidUpdateURL, "");
     return false;
   }
-  info->url_ = GURL(homepage_url_str);
+
+  info->url_ = GURL(tmp_update_url);
   if (!info->url_.is_valid() ||
-      (!info->url_.SchemeIs("http") &&
-       !info->url_.SchemeIs("https"))) {
+      info->url_.has_ref()) {
     *error = ErrorUtils::FormatErrorMessageUTF16(
-        errors::kInvalidHomepageURL, homepage_url_str);
+        errors::kInvalidUpdateURL, tmp_update_url);
     return false;
   }
-  extension->SetManifestData(keys::kHomepageURL, info.release());
+
+  extension->SetManifestData(keys::kUpdateURL, info.release());
   return true;
 }
 
 }  // namespace extensions