Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 1172583002: Add support for z-index: auto to AnimatableValues (Closed)

Created:
4 years, 10 months ago by alancutter (OOO until 2018)
Modified:
4 years, 10 months ago
Reviewers:
dstockwell
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, Eric Willigers, rjwright, shans
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add support for z-index: auto to AnimatableValues AnimatableValues did not support the auto keyword for z-index. This resulted in assertion failures when checking the new Interpolation pipeline against the old AnimatableValue pipeline. This patch adds support for this and resolves the assertion failure. BUG=497730 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197002

Patch Set 1 #

Patch Set 2 : Added equality stuff #

Patch Set 3 : Remove assert #

Patch Set 4 : Remove dumb #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M LayoutTests/animations/interpolation/z-index-interpolation.html View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/animation/css/CSSAnimatableValueFactory.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/animation/css/CSSPropertyEquality.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (8 generated)
alancutter (OOO until 2018)
4 years, 10 months ago (2015-06-09 07:06:01 UTC) #2
dstockwell
Looks like there's a similar bug in CSSPropertyEquality.
4 years, 10 months ago (2015-06-09 07:50:50 UTC) #3
alancutter (OOO until 2018)
On 2015/06/09 at 07:50:50, dstockwell wrote: > Looks like there's a similar bug in CSSPropertyEquality. ...
4 years, 10 months ago (2015-06-10 08:23:13 UTC) #4
dstockwell
lgtm
4 years, 10 months ago (2015-06-10 08:33:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1172583002/20001
4 years, 10 months ago (2015-06-10 08:33:26 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/65901)
4 years, 10 months ago (2015-06-10 09:12:12 UTC) #9
alancutter (OOO until 2018)
Removed zIndex() getter assertion as it was getting hit in other contexts, filed https://code.google.com/p/chromium/issues/detail?id=499651 for ...
4 years, 10 months ago (2015-06-12 01:45:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1172583002/40001
4 years, 10 months ago (2015-06-12 01:45:58 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/66305)
4 years, 10 months ago (2015-06-12 03:12:05 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1172583002/60001
4 years, 10 months ago (2015-06-12 04:41:52 UTC) #18
commit-bot: I haz the power
4 years, 10 months ago (2015-06-12 06:00:29 UTC) #19
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197002

Powered by Google App Engine
This is Rietveld 408576698