Issue 117253002: Add a new AssociationState DEPROVISIONED for cloud policy.

Issue 117253002: Add a new AssociationState DEPROVISIONED for cloud policy. (Closed)

Created:
7 years ago by Mattias Nissler (ping if slow)

Modified:
7 years ago

Reviewers:
bartfab (slow), Patrick Dubroy

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add a new AssociationState DEPROVISIONED for cloud policy. This adds a new enum value to Policy.AssociationState, indicating that the server side dropped the client from management. The association state is now also surfaced in the Status line in about:policy. BUG=chromium:329834 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242099

Patch Set 1 : Retrying upload... #

Patch Set 2 : Introduce new DEPROVISIONED state. #

Total comments: 2

Patch Set 3 : Address nit. #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -7 lines)			Patch
M	chrome/browser/policy/proto/cloud/device_management_backend.proto	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/policy_ui.cc	View	1 2	3 chunks	+34 lines, -7 lines	0 comments	Download
M	components/policy/proto/device_management_backend.proto	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	components/policy_strings.grdp	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

bartfab (slow)

lgtm https://codereview.chromium.org/117253002/diff/40001/chrome/browser/ui/webui/policy_ui.cc File chrome/browser/ui/webui/policy_ui.cc (right): https://codereview.chromium.org/117253002/diff/40001/chrome/browser/ui/webui/policy_ui.cc#newcode133 chrome/browser/ui/webui/policy_ui.cc:133: // Formats the association state indicated by |data|. ...

7 years ago (2013-12-19 11:00:21 UTC) #2

Mattias Nissler (ping if slow)

Patrick, can I get an OWNERS stamp for chrome/browser/ui/webui/policy_ui.cc?

7 years ago (2013-12-19 15:23:01 UTC) #3

Mattias Nissler (ping if slow)

https://codereview.chromium.org/117253002/diff/40001/chrome/browser/ui/webui/policy_ui.cc File chrome/browser/ui/webui/policy_ui.cc (right): https://codereview.chromium.org/117253002/diff/40001/chrome/browser/ui/webui/policy_ui.cc#newcode133 chrome/browser/ui/webui/policy_ui.cc:133: // Formats the association state indicated by |data|. If ...

7 years ago (2013-12-20 11:42:12 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnissler@chromium.org/117253002/60001

7 years ago (2013-12-20 11:43:05 UTC) #6

Message was sent while issue was closed.

Change committed as 242099

Expand Messages | Collapse Messages