Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 1172513002: Restore stock_arrow elemnt of the stocks2 demo (Closed)

Created:
5 years, 6 months ago by hansmuller1
Modified:
5 years, 6 months ago
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Restore stock_arrow element of the stocks2 demo This version doesn't add any visual punch. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f78353f231c75e373481b33f5b7f6a69ebdd8abc

Patch Set 1 #

Patch Set 2 : Updated per todays changes #

Total comments: 1

Patch Set 3 : Use Container width,height instead of constraints #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -75 lines) Patch
M sky/examples/stocks2/lib/stock_arrow.dart View 1 2 1 chunk +41 lines, -71 lines 0 comments Download
M sky/examples/stocks2/lib/stock_row.dart View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
hansmuller
PTAL
5 years, 6 months ago (2015-06-09 00:29:57 UTC) #3
abarth-chromium
s/elemnt/element
5 years, 6 months ago (2015-06-09 00:30:50 UTC) #4
abarth-chromium
LGTM https://codereview.chromium.org/1172513002/diff/20001/sky/examples/stocks2/lib/stock_arrow.dart File sky/examples/stocks2/lib/stock_arrow.dart (right): https://codereview.chromium.org/1172513002/diff/20001/sky/examples/stocks2/lib/stock_arrow.dart#newcode59 sky/examples/stocks2/lib/stock_arrow.dart:59: constraints: new BoxConstraints(minWidth: size, minHeight: size)); Why not ...
5 years, 6 months ago (2015-06-09 00:33:08 UTC) #5
hansmuller1
5 years, 6 months ago (2015-06-09 16:05:37 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
f78353f231c75e373481b33f5b7f6a69ebdd8abc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698