Enable setting the UINode key for ParentDataNodes

Added a key: parameter to ParentDataNode, ContentDataNode

The FlexExpandingChild flex parameter is now a keyword as
well, which adds a small readability benefit.

R=ianh@google.com

Committed: https://chromium.googlesource.com/external/mojo/+/f6a064a16b54dc638ae927e5379cee8b69eb6e4d

[hansmuller, 2015-06-09 17:32:18]

hansmuller@chromium.org changed reviewers:
+ ianh@google.com

[hansmuller, 2015-06-09 17:33:10]

hansmuller@chromium.org changed reviewers:
+ hansmuller@chromium.org

[hansmuller, 2015-06-09 17:33:10]

PTAL

[abarth-chromium, 2015-06-09 17:37:00]

abarth@chromium.org changed reviewers:
+ abarth@chromium.org

[abarth-chromium, 2015-06-09 17:37:01]

LGTM

https://codereview.chromium.org/1172503004/diff/1/sky/sdk/lib/framework/fn2.dart
File sky/sdk/lib/framework/fn2.dart (right):

https://codereview.chromium.org/1172503004/diff/1/sky/sdk/lib/framework/fn2.d...
sky/sdk/lib/framework/fn2.dart:157: ContentNode(UINode content, {Object key}) :
this.content = content, super(key: key);
We've been putting a space inside the { } so { Object key }

Not sure if that's real dart style or we just made it up.

[Hixie, 2015-06-09 17:40:08]

ianh@google.com changed reviewers:
- abarth@chromium.org

[Hixie, 2015-06-09 17:40:08]

lgtm

https://codereview.chromium.org/1172503004/diff/1/sky/sdk/lib/framework/fn2.dart
File sky/sdk/lib/framework/fn2.dart (right):

https://codereview.chromium.org/1172503004/diff/1/sky/sdk/lib/framework/fn2.d...
sky/sdk/lib/framework/fn2.dart:757: FlexExpandingChild(UINode content, {int
flex: 1, Object key})
I think I'd make the flex be an optional positional argument, and the key an
optional named argument. Having to explicitly give the 'flex' name everywhere is
redundant with the class name.

[hansmuller, 2015-06-09 17:47:40]

On 2015/06/09 17:40:08, Hixie wrote:
> lgtm
> 
>
https://codereview.chromium.org/1172503004/diff/1/sky/sdk/lib/framework/fn2.dart
> File sky/sdk/lib/framework/fn2.dart (right):
> 
>
https://codereview.chromium.org/1172503004/diff/1/sky/sdk/lib/framework/fn2.d...
> sky/sdk/lib/framework/fn2.dart:757: FlexExpandingChild(UINode content, {int
> flex: 1, Object key})
> I think I'd make the flex be an optional positional argument, and the key an
> optional named argument. Having to explicitly give the 'flex' name everywhere
is
> redundant with the class name.

Dart only allows either positional or named parameters. That's why I was selling
the advantage of 'flex:' a little :-).

[hansmuller, 2015-06-09 17:48:03]

https://codereview.chromium.org/1172503004/diff/1/sky/sdk/lib/framework/fn2.dart
File sky/sdk/lib/framework/fn2.dart (right):

https://codereview.chromium.org/1172503004/diff/1/sky/sdk/lib/framework/fn2.d...
sky/sdk/lib/framework/fn2.dart:157: ContentNode(UINode content, {Object key}) :
this.content = content, super(key: key);
On 2015/06/09 17:37:01, abarth wrote:
> We've been putting a space inside the { } so { Object key }
> 
> Not sure if that's real dart style or we just made it up.

Done.

I've been taking advantage of the fact that Sky style doesn't appear to be too
strict about lines that are wider than 80 chars. I hope that's OK.

[hansmuller1, 2015-06-09 18:00:55]

Committed patchset #3 (id:40001) manually as
f6a064a16b54dc638ae927e5379cee8b69eb6e4d (presubmit successful).

[abarth-chromium, 2015-06-09 18:59:17]

On 2015/06/09 at 17:48:03, hansmuller wrote:
> I've been taking advantage of the fact that Sky style doesn't appear to be too
strict about lines that are wider than 80 chars. I hope that's OK.

Yep.