Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: native_client_sdk/src/examples/hello_world_stdio/Makefile

Issue 11725003: Update make for hello examples (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: native_client_sdk/src/examples/hello_world_stdio/Makefile
diff --git a/native_client_sdk/src/examples/hello_world_stdio/Makefile b/native_client_sdk/src/examples/hello_world_stdio/Makefile
index 1f644cd8f75bf0cc44a46e558467e97e8dfe4373..28858b95296423cd3d6bd977045fb20bf83b467f 100644
--- a/native_client_sdk/src/examples/hello_world_stdio/Makefile
+++ b/native_client_sdk/src/examples/hello_world_stdio/Makefile
@@ -39,11 +39,20 @@ SOURCES=hello_world.c
# order should be symbol reference followed by symbol definition, with direct
# sources to the link (object files) are left most. In this case:
# hello_world -> ppapi_main -> ppapi_cpp -> ppapi -> pthread -> libc
-# Notice that pthread and libc are implied and come last through standard
-# compiler/link switches, for example -pthread.
-#
-LIBS=ppapi_main nacl_mounts ppapi_cpp ppapi
+# Notice that libc is implied and come last through standard compiler/link
+# switches.
+#
+# We break this list down into two parts, the set we need to rebuild (DEPS)
+# and the set we do not.
+#
+DEPS=ppapi_main
binji 2013/01/02 21:02:26 why do we need to rebuild ppapi_main?
noelallen1 2013/01/07 20:01:30 We provide the DEPS in case someone wants to modif
binji 2013/01/08 23:39:32 OK, seems like we'd want to include any buildable
noelallen_use_chromium 2013/01/09 17:48:46 Yes. nacl_mounts should be in there. It was remo
+LIBS=$(DEPS) ppapi_cpp ppapi pthread nacl_mounts
+
+#
+# Use the library dependency macro for each dependency
+#
+$(foreach dep,$(DEPS),$(eval $(call DEPEND_RULE,$(dep))))
#
# Use the compile macro for each source.

Powered by Google App Engine
This is Rietveld 408576698