chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm - Issue 1172483003: [MacViews] Update AppWindow when the native window changes fullscreen state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm

Issue 1172483003: [MacViews] Update AppWindow when the native window changes fullscreen state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@views

Patch Set: Don't remove ChromeNativeAppWindowViews::is_fullscreen_ Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/ui/views/apps/chrome_native_app_window_views_mac.h » ('j') | chrome/browser/ui/views/apps/chrome_native_app_window_views_mac.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm b/chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm

index 080cfce9defe6b13704eeb85e69290724e7c235f..69fdcd154e617465849e444ce17e699e70635508 100644

--- a/chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm

+++ b/chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm

@@ -763,11 +763,8 @@ void NativeAppWindowCocoa::WindowDidDeminiaturize() {

}

void NativeAppWindowCocoa::WindowDidEnterFullscreen() {

- if (!is_fullscreen_) {

- is_fullscreen_ = true;

- app_window_->OSFullscreen();

- }

- app_window_->OnNativeWindowChanged();

+ is_fullscreen_ = true;

+ app_window_->UpdateOSFullscreenState(true);

}

void NativeAppWindowCocoa::WindowDidExitFullscreen() {

@@ -775,8 +772,7 @@ void NativeAppWindowCocoa::WindowDidExitFullscreen() {

if (!shows_fullscreen_controls_)

gfx::SetNSWindowCanFullscreen(window(), false);

- app_window_->Restore();

- app_window_->OnNativeWindowChanged();

+ app_window_->UpdateOSFullscreenState(false);

}

void NativeAppWindowCocoa::WindowWillZoom() {