Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3446)

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_contentscript_unittest.cc

Issue 11724002: Move ContentScripts out of Extension (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_unref_browser_action
Patch Set: Latest master for CQ Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest_tests/extension_manifests_contentscript_unittest.cc
diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_contentscript_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_contentscript_unittest.cc
deleted file mode 100644
index 84708932a569bab4bef17330e7861ac9da68ddad..0000000000000000000000000000000000000000
--- a/chrome/common/extensions/manifest_tests/extension_manifests_contentscript_unittest.cc
+++ /dev/null
@@ -1,49 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "base/command_line.h"
-#include "base/strings/string_number_conversions.h"
-#include "chrome/common/chrome_switches.h"
-#include "chrome/common/extensions/extension.h"
-#include "chrome/common/extensions/extension_manifest_constants.h"
-#include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
-#include "extensions/common/error_utils.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-namespace errors = extension_manifest_errors;
-
-TEST_F(ExtensionManifestTest, ContentScriptMatchPattern) {
- Testcase testcases[] = {
- // chrome:// urls are not allowed.
- Testcase("content_script_chrome_url_invalid.json",
- extensions::ErrorUtils::FormatErrorMessage(
- errors::kInvalidMatch,
- base::IntToString(0),
- base::IntToString(0),
- URLPattern::GetParseResultString(
- URLPattern::PARSE_ERROR_INVALID_SCHEME))),
-
- // Match paterns must be strings.
- Testcase("content_script_match_pattern_not_string.json",
- extensions::ErrorUtils::FormatErrorMessage(errors::kInvalidMatch,
- base::IntToString(0),
- base::IntToString(0),
- errors::kExpectString))
- };
- RunTestcases(testcases, arraysize(testcases),
- EXPECT_TYPE_ERROR);
-
- LoadAndExpectSuccess("ports_in_content_scripts.json");
-}
-
-TEST_F(ExtensionManifestTest, ContentScriptsOnChromeUrlsWithFlag) {
- CommandLine::ForCurrentProcess()->AppendSwitch(
- switches::kExtensionsOnChromeURLs);
- std::string error;
- scoped_refptr<extensions::Extension> extension =
- LoadAndExpectSuccess("content_script_chrome_url_invalid.json");
- EXPECT_EQ("", error);
- const GURL newtab_url("chrome://newtab/");
- EXPECT_TRUE(extension->HasContentScriptAtURL(newtab_url));
-}

Powered by Google App Engine
This is Rietveld 408576698