chrome/common/extensions/manifest_tests/extension_manifests_contentscript_unittest.cc - Issue 11724002: Move ContentScripts out of Extension

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/manifest_tests/extension_manifests_contentscript_unittest.cc

Issue 11724002: Move ContentScripts out of Extension (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_unref_browser_action

Patch Set: Latest master for CQ Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/common/extensions/manifest_handlers/exclude_matches_manifest_unittest.cc ('k') | chrome/common/extensions/manifest_tests/extension_manifests_excludematches_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	(Empty)
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.

4

5 #include "base/command_line.h"

6 #include "base/strings/string_number_conversions.h"

7 #include "chrome/common/chrome_switches.h"

8 #include "chrome/common/extensions/extension.h"

9 #include "chrome/common/extensions/extension_manifest_constants.h"

10 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"

11 #include "extensions/common/error_utils.h"

12 #include "testing/gtest/include/gtest/gtest.h"

13

14 namespace errors = extension_manifest_errors;

15

16 TEST_F(ExtensionManifestTest, ContentScriptMatchPattern) {

17 Testcase testcases[] = {

18 // chrome:// urls are not allowed.

19 Testcase("content_script_chrome_url_invalid.json",

20 extensions::ErrorUtils::FormatErrorMessage(

21 errors::kInvalidMatch,

22 base::IntToString(0),

23 base::IntToString(0),

24 URLPattern::GetParseResultString(

25 URLPattern::PARSE_ERROR_INVALID_SCHEME))),

26

27 // Match paterns must be strings.

28 Testcase("content_script_match_pattern_not_string.json",

29 extensions::ErrorUtils::FormatErrorMessage(errors::kInvalidMatch,

30 base::IntToString(0),

31 base::IntToString(0),

32 errors::kExpectString))

33 };

34 RunTestcases(testcases, arraysize(testcases),

35 EXPECT_TYPE_ERROR);

36

37 LoadAndExpectSuccess("ports_in_content_scripts.json");

38 }

39

40 TEST_F(ExtensionManifestTest, ContentScriptsOnChromeUrlsWithFlag) {

41 CommandLine::ForCurrentProcess()->AppendSwitch(

42 switches::kExtensionsOnChromeURLs);

43 std::string error;

44 scoped_refptr<extensions::Extension> extension =

45 LoadAndExpectSuccess("content_script_chrome_url_invalid.json");

46 EXPECT_EQ("", error);

47 const GURL newtab_url("chrome://newtab/");

48 EXPECT_TRUE(extension->HasContentScriptAtURL(newtab_url));

49 }

OLD	NEW