Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1172363002: Revert of update.py: Check out and build libc++ libc++abi on OS X, set deployment target. (Closed)

Created:
5 years, 6 months ago by Nico
Modified:
5 years, 6 months ago
Reviewers:
hans
CC:
chromium-reviews, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of update.py: Check out and build libc++ libc++abi on OS X, set deployment target. (patchset #3 id:40001 of https://codereview.chromium.org/1169353002/) Reason for revert: broke clang/win tot bots Original issue's description: > update.py: Check out and build libc++ libc++abi on OS X, set deployment target. > > I had hoped to bump the deployment target to 10.7 instead, but the nacl bots > still build on 10.6 :-( > > Also, pass commands as a single string to subprocess when > shell=True (else, 2nd cmd entry and onward are treated as > shell parameters, not as part of the command). > > BUG=494442 > > Committed: https://crrev.com/8fe06c48bbe07670dba3cafdd4c613f0008948f9 > Cr-Commit-Position: refs/heads/master@{#333669} TBR=hans@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=494442 Committed: https://crrev.com/6a120cded321773b6851e566470c3bd08c7bb714 Cr-Commit-Position: refs/heads/master@{#333737}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -98 lines) Patch
M tools/clang/scripts/update.py View 9 chunks +21 lines, -95 lines 0 comments Download
M tools/clang/scripts/update.sh View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
Created Revert of update.py: Check out and build libc++ libc++abi on OS X, set deployment ...
5 years, 6 months ago (2015-06-10 15:27:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1172363002/1
5 years, 6 months ago (2015-06-10 15:27:28 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-10 15:28:20 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 15:29:13 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a120cded321773b6851e566470c3bd08c7bb714
Cr-Commit-Position: refs/heads/master@{#333737}

Powered by Google App Engine
This is Rietveld 408576698