Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: src/factory.cc

Issue 1172333002: MIPS64: Fix memory allocation when code range is used for LO space only. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Remove ifdefs and make checks valid on mips64. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/heap/heap.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/factory.cc
diff --git a/src/factory.cc b/src/factory.cc
index a16e6fba05edbc7c63e16b54ca3d541531d85c43..8e395b328e1ad0cb09c0a1047e76d90822a4a326 100644
--- a/src/factory.cc
+++ b/src/factory.cc
@@ -1436,9 +1436,9 @@ Handle<Code> Factory::NewCode(const CodeDesc& desc,
int obj_size = Code::SizeFor(body_size);
Handle<Code> code = NewCodeRaw(obj_size, immovable);
- DCHECK(isolate()->code_range() == NULL ||
- !isolate()->code_range()->valid() ||
- isolate()->code_range()->contains(code->address()));
+ DCHECK(isolate()->code_range() == NULL || !isolate()->code_range()->valid() ||
+ isolate()->code_range()->contains(code->address()) ||
+ obj_size <= isolate()->heap()->code_space()->AreaSize());
// The code object has not been fully initialized yet. We rely on the
// fact that no allocation will happen from this point on.
« no previous file with comments | « no previous file | src/heap/heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698