Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1172333002: MIPS64: Fix memory allocation when code range is used for LO space only. (Closed)

Created:
5 years, 6 months ago by dusmil.imgtec
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Fix memory allocation when code range is used for LO space only. Allocation must respect requested reserve size, not requested commit area size. Additionally fix check failures in debug mode for mips64. After CL: https://codereview.chromium.org/1147503002/ memory for large code objects is allocated from code range, memory for regular code objects is allocated normally. TEST=cctest/test-spaces/MemoryChunk BUG= Committed: https://crrev.com/a5b0a3e298c9e8eb5917040c6f7ed2f0b919b123 Cr-Commit-Position: refs/heads/master@{#28995}

Patch Set 1 #

Patch Set 2 : Remove ifdefs and make checks valid on mips64. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M src/factory.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/heap/heap.cc View 1 3 chunks +7 lines, -3 lines 0 comments Download
M src/heap/spaces.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
dusmil.imgtec
5 years, 6 months ago (2015-06-10 13:26:45 UTC) #2
Hannes Payer (out of office)
Instead of adding the MIPS defs everywhere, can we make the check valid instead?
5 years, 6 months ago (2015-06-11 01:46:29 UTC) #3
dusmil.imgtec
Yes, I do not like them either. PTAL.
5 years, 6 months ago (2015-06-11 12:31:51 UTC) #4
Hannes Payer (out of office)
lgtm
5 years, 6 months ago (2015-06-12 05:16:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1172333002/20001
5 years, 6 months ago (2015-06-12 10:59:55 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-12 11:42:11 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 11:42:29 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a5b0a3e298c9e8eb5917040c6f7ed2f0b919b123
Cr-Commit-Position: refs/heads/master@{#28995}

Powered by Google App Engine
This is Rietveld 408576698