Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 1172323002: roll_webrtc.py: Improve no-op roll message. (Closed)

Created:
5 years, 6 months ago by kjellander_chromium
Modified:
5 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

roll_webrtc.py: Improve no-op roll message. Currently there's no information printed when the execution of the roll script is a no-op (e.g. when the latest revision is already rolled). BUG= Committed: https://crrev.com/fb7186b3d00c9c733f99fa3467096cf4e86459e2 Cr-Commit-Position: refs/heads/master@{#333722}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/roll_webrtc.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
kjellander_chromium
5 years, 6 months ago (2015-06-10 11:25:29 UTC) #2
henrika_webrtc
LGTM
5 years, 6 months ago (2015-06-10 11:36:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1172323002/1
5 years, 6 months ago (2015-06-10 11:41:33 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 6 months ago (2015-06-10 11:41:36 UTC) #7
henrika (OOO until Aug 14)
LGTM
5 years, 6 months ago (2015-06-10 11:49:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1172323002/1
5 years, 6 months ago (2015-06-10 11:50:32 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-10 11:58:34 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 11:59:25 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fb7186b3d00c9c733f99fa3467096cf4e86459e2
Cr-Commit-Position: refs/heads/master@{#333722}

Powered by Google App Engine
This is Rietveld 408576698