Merge page serializers [9/12]

Add new html elements test

Add new PageSerializerTest.HTMLElements test based on
WebPageSerializerTest.HTMLNodes which will be removed together with the
old serializer in a later commit. The new test covers
PageSerializerTest.InputImage so that test is removed.

To correctly include all resources for an element the
presentationAttributeStyle for must also be processed.

--

This review is part of set aiming to merge the two existing page
serializers, WebPageSerializerImpl and PageSerializer into the latter
one.

In addition to this it moves all the old tests from
WebPageNewSerializerTest and WebPageSerializerTest to the newer
PageSerializerTest structure and splits out a test for MHTML into the
MHTMLTest file.

Note: This is a rebase and split of
https://codereview.chromium.org/68613003 from Opera which was reverted
due to failing tests. In addition to the rebase some smaller fixes was
done to accommodate to changes in the code from when it was first
landed.

BUG=328354
R=hajimehoshi@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197021

[Tiger (Sony Mobile), 2015-06-10 10:38:58]

PTAL

[hajimehoshi, 2015-06-11 00:58:21]

https://codereview.chromium.org/1172303002/diff/1/Source/web/tests/data/pages...
File Source/web/tests/data/pageserializer/elements/text.txt (right):

https://codereview.chromium.org/1172303002/diff/1/Source/web/tests/data/pages...
Source/web/tests/data/pageserializer/elements/text.txt:1: Empty
I'm not sure the context, but 'empty.txt' is a better name?

[Tiger (Sony Mobile), 2015-06-11 07:43:31]

https://codereview.chromium.org/1172303002/diff/1/Source/web/tests/data/pages...
File Source/web/tests/data/pageserializer/elements/text.txt (right):

https://codereview.chromium.org/1172303002/diff/1/Source/web/tests/data/pages...
Source/web/tests/data/pageserializer/elements/text.txt:1: Empty
On 2015/06/11 00:58:21, hajimehoshi wrote:
> I'm not sure the context, but 'empty.txt' is a better name?

Done.

[hajimehoshi, 2015-06-12 06:39:14]

lgtm

[philipj_slow, 2015-06-12 07:52:00]

philipj@opera.com changed reviewers:
+ philipj@opera.com

[philipj_slow, 2015-06-12 07:52:01]

https://codereview.chromium.org/1172303002/diff/20001/Source/web/tests/data/p...
File Source/web/tests/data/pageserializer/elements/elements.html (right):

https://codereview.chromium.org/1172303002/diff/20001/Source/web/tests/data/p...
Source/web/tests/data/pageserializer/elements/elements.html:1: <!-- This page is
used to test that PageSerializer correctly serializes the
I'd be interested to see what happens with <audio src>, <video src>, <video
poster>, <source src> and <track src>. Even if they're not serialized,
documenting that it is so is valuable. Unless there are already other tests.

[philipj_slow, 2015-06-12 08:04:48]

On 2015/06/12 07:52:01, philipj wrote:
>
https://codereview.chromium.org/1172303002/diff/20001/Source/web/tests/data/p...
> File Source/web/tests/data/pageserializer/elements/elements.html (right):
> 
>
https://codereview.chromium.org/1172303002/diff/20001/Source/web/tests/data/p...
> Source/web/tests/data/pageserializer/elements/elements.html:1: <!-- This page
is
> used to test that PageSerializer correctly serializes the
> I'd be interested to see what happens with <audio src>, <video src>, <video
> poster>, <source src> and <track src>. Even if they're not serialized,
> documenting that it is so is valuable. Unless there are already other tests.

Tiger pointed me on IRC to "FIXME: For object (plugins) tags and video tag we
could replace them by an image of their current contents." in PageSerializer.cpp
and the fact that none of these media-related elements work at all. I withdraw
my suggestion to document that here with failing tests.

[philipj_slow, 2015-06-12 08:04:55]

The CQ bit was checked by philipj@opera.com

[philipj_slow, 2015-06-12 08:04:55]

lgtm

[commit-bot: I haz the power, 2015-06-12 08:05:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1172303002/20001

[Tiger (Sony Mobile), 2015-06-12 08:12:21]

https://codereview.chromium.org/1172303002/diff/20001/Source/web/tests/data/p...
File Source/web/tests/data/pageserializer/elements/elements.html (right):

https://codereview.chromium.org/1172303002/diff/20001/Source/web/tests/data/p...
Source/web/tests/data/pageserializer/elements/elements.html:1: <!-- This page is
used to test that PageSerializer correctly serializes the
On 2015/06/12 07:52:01, philipj wrote:
> I'd be interested to see what happens with <audio src>, <video src>, <video
> poster>, <source src> and <track src>. Even if they're not serialized,
> documenting that it is so is valuable. Unless there are already other tests.

It's mentioned a bit about this in PageSerializer.cpp: "FIXME: For object
(plugins) tags and video tag we could replace them by an image of their current
contents.", but other than that there is no documentation. Sadly the serializers
is behind on newer standards and not everything should be serialized as well.
Hopefully having one serializer instead of two will make it a bit easier to
improve the state of it.

[commit-bot: I haz the power, 2015-06-12 09:09:27]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197021