Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(56)

Issue 1172253002: Componentization: enable linking core and modules separately. (Closed)

Created:
4 years, 10 months ago by tasak
Modified:
4 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Componentization: enable linking core and modules separately. BUG=358074 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196852

Patch Set 1 #

Patch Set 2 : Fixed feature defines. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/build/features.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
tasak
PTAL?
4 years, 10 months ago (2015-06-10 05:59:53 UTC) #2
haraken
LGTM
4 years, 10 months ago (2015-06-10 07:00:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1172253002/1
4 years, 10 months ago (2015-06-10 07:48:09 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/58329)
4 years, 10 months ago (2015-06-10 08:28:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1172253002/20001
4 years, 10 months ago (2015-06-10 08:51:23 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=196852
4 years, 10 months ago (2015-06-10 09:51:57 UTC) #11
Nico
4 years, 10 months ago (2015-06-10 14:44:38 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1173073002/ by thakis@chromium.org.

The reason for reverting is: See
https://code.google.com/p/chromium/issues/detail?id=492283#c38.

Powered by Google App Engine
This is Rietveld 408576698