Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: vm/assembler_x64.cc

Issue 11722026: Do not emit pointer information for embedded singleton VM Isolate objects while generating code. Th… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/assembler_ia32.cc ('k') | vm/heap.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/assembler_x64.cc
===================================================================
--- vm/assembler_x64.cc (revision 16644)
+++ vm/assembler_x64.cc (working copy)
@@ -1649,7 +1649,7 @@
void Assembler::LoadObject(Register dst, const Object& object) {
- if (object.IsSmi() || object.IsNull()) {
+ if (object.IsSmi() || object.InVMHeap()) {
movq(dst, Immediate(reinterpret_cast<int64_t>(object.raw())));
} else {
ASSERT(object.IsNotTemporaryScopedHandle());
@@ -1663,7 +1663,7 @@
void Assembler::StoreObject(const Address& dst, const Object& object) {
- if (object.IsSmi() || object.IsNull()) {
+ if (object.IsSmi() || object.InVMHeap()) {
movq(dst, Immediate(reinterpret_cast<int64_t>(object.raw())));
} else {
ASSERT(object.IsNotTemporaryScopedHandle());
@@ -1675,7 +1675,7 @@
void Assembler::PushObject(const Object& object) {
- if (object.IsSmi() || object.IsNull()) {
+ if (object.IsSmi() || object.InVMHeap()) {
pushq(Immediate(reinterpret_cast<int64_t>(object.raw())));
} else {
LoadObject(TMP, object);
@@ -1685,7 +1685,7 @@
void Assembler::CompareObject(Register reg, const Object& object) {
- if (object.IsSmi() || object.IsNull()) {
+ if (object.IsSmi() || object.InVMHeap()) {
cmpq(reg, Immediate(reinterpret_cast<int64_t>(object.raw())));
} else {
ASSERT(reg != TMP);
« no previous file with comments | « vm/assembler_ia32.cc ('k') | vm/heap.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698