Issue 11722012: Add fuzziness to checking whether two SkBitmaps are equal for ImageTest.*

Issue 11722012: Add fuzziness to checking whether two SkBitmaps are equal for ImageTest.* (Closed)

Created:
7 years, 11 months ago by pkotwicz

Modified:
7 years, 11 months ago

Reviewers:
Robert Sesek

CC:
chromium-reviews, rsesek+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add fuzziness to checking whether the colors of two SkBitmaps are equal for ImageTest.* BUG=153782, 152203, 161377 Test=Tests pass on all Mac bots Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175184

Patch Set 4 : #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -37 lines)			Patch
D	tools/valgrind/gtest_exclude/ui_unittests.gtest_mac.txt	View	1	1 chunk	+0 lines, -10 lines	0 comments	Download
M	ui/gfx/image/image_unittest.cc	View		7 chunks	+13 lines, -13 lines	0 comments	Download
M	ui/gfx/image/image_unittest_util.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/gfx/image/image_unittest_util.cc	View	1 2 3	5 chunks	+24 lines, -13 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Robert Sesek

https://codereview.chromium.org/11722012/diff/5001/tools/valgrind/gtest_exclude/ui_unittests.gtest_mac.txt File tools/valgrind/gtest_exclude/ui_unittests.gtest_mac.txt (left): https://codereview.chromium.org/11722012/diff/5001/tools/valgrind/gtest_exclude/ui_unittests.gtest_mac.txt#oldcode1 tools/valgrind/gtest_exclude/ui_unittests.gtest_mac.txt:1: # See crbug.com/152203 Is this file found automatically or ...

7 years, 11 months ago (2013-01-03 17:37:52 UTC) #2

pkotwicz

7 years, 11 months ago (2013-01-03 18:02:49 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/11722012/8002

7 years, 11 months ago (2013-01-04 16:27:10 UTC) #5

Message was sent while issue was closed.

Change committed as 175184

Expand Messages | Collapse Messages