third_party/zlib/google/zip_reader.cc - Issue 1172183002: Move StartsWith[ASCII] to base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/zlib/google/zip_reader.cc

Issue 1172183002: Move StartsWith[ASCII] to base namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@string_util3

Patch Set: merger Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/zlib/google/zip_reader.cc

diff --git a/third_party/zlib/google/zip_reader.cc b/third_party/zlib/google/zip_reader.cc

index c9f728c051ef1ec8a7c758aef58fb4117283936b..3acbb418d21cf905fc8861e5518de281b2497c65 100644

--- a/third_party/zlib/google/zip_reader.cc

+++ b/third_party/zlib/google/zip_reader.cc

@@ -145,7 +145,8 @@ ZipReader::EntryInfo::EntryInfo(const std::string& file_name_in_zip,

// We also consider that the file name is unsafe, if it's absolute.

// On Windows, IsAbsolute() returns false for paths starting with "/".

- if (file_path_.IsAbsolute() || StartsWithASCII(file_name_in_zip, "/", false))

+ if (file_path_.IsAbsolute() ||

+ base::StartsWithASCII(file_name_in_zip, "/", false))

is_unsafe_ = true;

// Construct the last modified time. The timezone info is not present in