net/ssl/ssl_cipher_suite_names.cc - Issue 1172183002: Move StartsWith[ASCII] to base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/ssl/ssl_cipher_suite_names.cc

Issue 1172183002: Move StartsWith[ASCII] to base namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@string_util3

Patch Set: merger Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/ssl/ssl_cipher_suite_names.cc

diff --git a/net/ssl/ssl_cipher_suite_names.cc b/net/ssl/ssl_cipher_suite_names.cc

index 87a3259e54ccf689cd0e4af388f28f8e6c2dac66..6a2dff18b6ac10d1d2180b987d24200e931d4782 100644

--- a/net/ssl/ssl_cipher_suite_names.cc

+++ b/net/ssl/ssl_cipher_suite_names.cc

@@ -349,7 +349,8 @@ bool ParseSSLCipherString(const std::string& cipher_string,

uint16* cipher_suite) {

int value = 0;

if (cipher_string.size() == 6 &&

- StartsWithASCII(cipher_string, "0x", false /* case insensitive */) &&

+ base::StartsWithASCII(cipher_string, "0x",

+ false /* case insensitive */) &&

base::HexStringToInt(cipher_string, &value)) {

*cipher_suite = static_cast<uint16>(value);

return true;