Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7931)

Unified Diff: chrome/tools/profile_reset/jtl_compiler_unittest.cc

Issue 1172183002: Move StartsWith[ASCII] to base namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@string_util3
Patch Set: merger Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/server/http_handler.cc ('k') | chrome/tools/profile_reset/jtl_parser_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/tools/profile_reset/jtl_compiler_unittest.cc
diff --git a/chrome/tools/profile_reset/jtl_compiler_unittest.cc b/chrome/tools/profile_reset/jtl_compiler_unittest.cc
index cb6fea213ad11aa728582e3f797623ff7494037c..c39e59a4ac2ad51166da796f46bb43e2298be25e 100644
--- a/chrome/tools/profile_reset/jtl_compiler_unittest.cc
+++ b/chrome/tools/profile_reset/jtl_compiler_unittest.cc
@@ -113,7 +113,8 @@ TEST(JtlCompiler, InvalidOperationName) {
JtlCompiler::CompileError error;
EXPECT_FALSE(
JtlCompiler::Compile(kSourceCode, kTestHashSeed, &bytecode, &error));
- EXPECT_THAT(error.context, testing::StartsWith("non_existent_instruction"));
+ EXPECT_THAT(error.context,
+ testing::base::StartsWith("non_existent_instruction"));
EXPECT_EQ(2u, error.line_number);
EXPECT_EQ(JtlCompiler::CompileError::INVALID_OPERATION_NAME,
error.error_code);
@@ -130,7 +131,7 @@ TEST(JtlCompiler, InvalidArgumentsCount) {
JtlCompiler::CompileError error;
EXPECT_FALSE(JtlCompiler::Compile(
kSourceCodes[i], kTestHashSeed, &bytecode, &error));
- EXPECT_THAT(error.context, testing::StartsWith("store_bool"));
+ EXPECT_THAT(error.context, testing::base::StartsWith("store_bool"));
EXPECT_EQ(1u, error.line_number);
EXPECT_EQ(JtlCompiler::CompileError::INVALID_ARGUMENT_COUNT,
error.error_code);
@@ -162,7 +163,7 @@ TEST(JtlCompiler, InvalidArgumentType) {
EXPECT_FALSE(JtlCompiler::Compile(
cases[i].source_code, kTestHashSeed, &bytecode, &error));
EXPECT_THAT(error.context,
- testing::StartsWith(cases[i].expected_context_prefix));
+ testing::base::StartsWith(cases[i].expected_context_prefix));
EXPECT_EQ(2u, error.line_number);
EXPECT_EQ(JtlCompiler::CompileError::INVALID_ARGUMENT_TYPE,
error.error_code);
@@ -183,7 +184,7 @@ TEST(JtlCompiler, InvalidArgumentValue) {
EXPECT_FALSE(JtlCompiler::Compile(
cases[i].source_code, kTestHashSeed, &bytecode, &error));
EXPECT_THAT(error.context,
- testing::StartsWith(cases[i].expected_context_prefix));
+ testing::base::StartsWith(cases[i].expected_context_prefix));
EXPECT_EQ(0u, error.line_number);
EXPECT_EQ(JtlCompiler::CompileError::INVALID_ARGUMENT_VALUE,
error.error_code);
@@ -209,7 +210,7 @@ TEST(JtlCompiler, ParsingError) {
JtlCompiler::CompileError error;
EXPECT_FALSE(
JtlCompiler::Compile(kSourceCode, kTestHashSeed, &bytecode, &error));
- EXPECT_THAT(error.context, testing::StartsWith("go"));
+ EXPECT_THAT(error.context, testing::base::StartsWith("go"));
EXPECT_EQ(1u, error.line_number);
EXPECT_EQ(JtlCompiler::CompileError::PARSING_ERROR, error.error_code);
}
« no previous file with comments | « chrome/test/chromedriver/server/http_handler.cc ('k') | chrome/tools/profile_reset/jtl_parser_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698