Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1172173002: Clean up a bunch of our Dart code. (Closed)

Created:
5 years, 6 months ago by Hixie
Modified:
5 years, 6 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Clean up a bunch of our Dart code. - constructors first - have either a blank line at the top and bottom of each class, or no blank line in either place (it's still inconsistent about which we should do) - hide clamp() R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/262ab6f12a1e59f6ab393e6d8893ea7346ec7bda

Patch Set 1 #

Patch Set 2 : upstream merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+293 lines, -224 lines) Patch
M sky/engine/core/painting/Color.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M sky/engine/core/painting/Point.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/engine/core/painting/Rect.dart View 3 chunks +14 lines, -16 lines 0 comments Download
M sky/engine/core/painting/Size.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M sky/sdk/lib/framework/components2/button.dart View 3 chunks +4 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/components2/button_base.dart View 2 chunks +2 lines, -1 line 0 comments Download
M sky/sdk/lib/framework/components2/checkbox.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/components2/drawer.dart View 1 3 chunks +8 lines, -5 lines 0 comments Download
M sky/sdk/lib/framework/components2/drawer_header.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/components2/floating_action_button.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/components2/icon.dart View 3 chunks +4 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/components2/icon_button.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/components2/ink_splash.dart View 4 chunks +36 lines, -32 lines 0 comments Download
M sky/sdk/lib/framework/components2/ink_well.dart View 3 chunks +4 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/components2/input.dart View 3 chunks +15 lines, -13 lines 0 comments Download
M sky/sdk/lib/framework/components2/material.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/components2/menu_item.dart View 3 chunks +3 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/components2/modal_overlay.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/components2/popup_menu.dart View 1 3 chunks +9 lines, -7 lines 0 comments Download
M sky/sdk/lib/framework/components2/popup_menu_item.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/components2/radio.dart View 3 chunks +5 lines, -3 lines 0 comments Download
M sky/sdk/lib/framework/components2/scrollable.dart View 3 chunks +5 lines, -4 lines 0 comments Download
M sky/sdk/lib/framework/components2/tool_bar.dart View 3 chunks +6 lines, -4 lines 0 comments Download
M sky/sdk/lib/framework/fn2.dart View 1 27 chunks +133 lines, -96 lines 0 comments Download
M sky/sdk/lib/framework/rendering/box.dart View 2 chunks +11 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/rendering/object.dart View 1 chunk +0 lines, -7 lines 0 comments Download
M sky/sdk/lib/framework/rendering/paragraph.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 6 months ago (2015-06-09 22:18:49 UTC) #2
Hixie
5 years, 6 months ago (2015-06-09 22:28:03 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
262ab6f12a1e59f6ab393e6d8893ea7346ec7bda (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698