Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 117213003: Telemetry: Fix string matching bug in timeline metric. (Closed)

Created:
7 years ago by epenner
Modified:
7 years ago
CC:
chromium-reviews, chrome-speed-team+watch_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Telemetry: Fix string matching bug in timeline metric. My previous change to simplify actually made the matching incorrect. BUG=321439 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242047

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M tools/perf/metrics/timeline.py View 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
epenner
Oops. Ptal.
7 years ago (2013-12-19 03:32:12 UTC) #1
ernstm
On 2013/12/19 03:32:12, epenner wrote: > Oops. Ptal. LGTM
7 years ago (2013-12-19 05:55:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/epenner@chromium.org/117213003/1
7 years ago (2013-12-19 19:11:52 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=108194
7 years ago (2013-12-20 00:17:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/epenner@chromium.org/117213003/1
7 years ago (2013-12-20 00:36:02 UTC) #5
commit-bot: I haz the power
7 years ago (2013-12-20 08:59:46 UTC) #6
Message was sent while issue was closed.
Change committed as 242047

Powered by Google App Engine
This is Rietveld 408576698