Issue 1172123003: Fix the Sky tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1172123003: Fix the Sky tests (Closed)

Created:
5 years, 6 months ago by abarth-chromium

Modified:
5 years, 6 months ago

Reviewers:
Hixie

CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Fix the Sky tests Instead of triggering layout synchronously during AppView construction, we now schedule the initial layout using a magic bootstrapping function. TBR=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/1873bd7997e11a335be7e592674892793d13de3d

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -6 lines)			Patch
M	sky/sdk/lib/framework/app.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/sdk/lib/framework/rendering/box.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/sdk/lib/framework/rendering/object.dart	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	sky/tests/raw/padding_deflate.dart	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	sky/tests/raw/render_box.dart	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	sky/tests/resources/display_list.dart	View	1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

abarth-chromium

Committed patchset #1 (id:1) manually as 1873bd7997e11a335be7e592674892793d13de3d (presubmit successful).

5 years, 6 months ago (2015-06-09 21:07:22 UTC) #1

Message was sent while issue was closed.

lgtm