Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 1172123002: Revert of html_viewer: Add DevToolsAgentImpl. (Closed)

Created:
5 years, 6 months ago by yzshen1
Modified:
5 years, 6 months ago
Reviewers:
dgozman, sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, yurys, devtools-reviews_chromium.org, darin (slow to review), ben+mojo_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of html_viewer: Add DevToolsAgentImpl. (patchset #5 id:80001 of https://codereview.chromium.org/1163953002/) Reason for revert: Maybe the reason of the html_viewer_apptests flakiness: http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Linux/builds/9552 Running mojo:html_viewer_apptests... DEBUG:Tests for mojo:html_viewer_apptests: AXProviderTest. HelloWorld DEBUG:Command: /mnt/data/b/build/slave/chromium_mojo/build/src/out/Release/mojo_runner --gtest_filter=AXProviderTest.HelloWorld mojo:html_viewer_apptests [ FAILED ] Command (exit code -11): /mnt/data/b/build/slave/chromium_mojo/build/src/out/Release/mojo_runner --gtest_filter=AXProviderTest.HelloWorld mojo:html_viewer_apptests Original issue's description: > html_viewer: Add DevToolsAgentImpl. > > DevToolsAgentImpl connects the DevTools mojo service with the DevTools agent support in blink. > > BUG=478249 > > Committed: https://crrev.com/32166090d27c6450957f59eedaa6ea5fa12762e4 > Cr-Commit-Position: refs/heads/master@{#333516} TBR=sky@chromium.org,dgozman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=478249 Committed: https://crrev.com/2008a972161fbf2359fe77c67d16f36539f8098b Cr-Commit-Position: refs/heads/master@{#333570}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -184 lines) Patch
M components/devtools_service/public/interfaces/devtools_service.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M components/html_viewer/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
D components/html_viewer/devtools_agent_impl.h View 1 chunk +0 lines, -56 lines 0 comments Download
D components/html_viewer/devtools_agent_impl.cc View 1 chunk +0 lines, -107 lines 0 comments Download
M components/html_viewer/html_document.h View 2 chunks +0 lines, -3 lines 0 comments Download
M components/html_viewer/html_document.cc View 3 chunks +2 lines, -11 lines 0 comments Download
M mandoline/app/android/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
yzshen1
Created Revert of html_viewer: Add DevToolsAgentImpl.
5 years, 6 months ago (2015-06-09 20:55:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1172123002/1
5 years, 6 months ago (2015-06-09 20:57:51 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-09 21:00:06 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 21:00:54 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2008a972161fbf2359fe77c67d16f36539f8098b
Cr-Commit-Position: refs/heads/master@{#333570}

Powered by Google App Engine
This is Rietveld 408576698