Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1172033003: Add a basic InkWell implementation (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 6 months ago
Reviewers:
Hixie
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add a basic InkWell implementation This CL replaces the (non-working) components2 InkWell with some code based on the ink_well example. There are at least two issues with the implementation: 1) The ink splash always starts at the center of the well because we don't have a facility for converting from global to local coordinates, which means we can't tell where the tap occurred in the local coordinates we need to use for painting. 2) When used inside a MenuItem, the in splash disappears shortly after starting, presumably because the button starts highlighting, which causes a component rebuild and somehow we lose the RenderInkWell instance. I plan to address these issues in subsequent CLs. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/c81f8ce3200f69ed9b43745d78dc2560d9e875d3

Patch Set 1 #

Patch Set 2 : rm examples/raw/ink_well.dart #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -320 lines) Patch
D sky/examples/raw/ink_well.dart View 1 1 chunk +0 lines, -70 lines 0 comments Download
M sky/sdk/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D sky/sdk/lib/framework/components2/ink_splash.dart View 1 chunk +0 lines, -144 lines 0 comments Download
M sky/sdk/lib/framework/components2/ink_well.dart View 1 chunk +106 lines, -105 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
abarth-chromium
5 years, 6 months ago (2015-06-10 15:30:09 UTC) #1
Hixie
lgtm
5 years, 6 months ago (2015-06-10 15:56:35 UTC) #2
Hixie
but put your constructors first, then your fields
5 years, 6 months ago (2015-06-10 15:56:47 UTC) #3
abarth-chromium
5 years, 6 months ago (2015-06-10 16:04:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c81f8ce3200f69ed9b43745d78dc2560d9e875d3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698