Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1172013002: [turbofan] Fix context chain extension for top-level code. (Closed)

Created:
5 years, 6 months ago by Michael Starzinger
Modified:
5 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix context chain extension for top-level code. For top-level code the closure passed into context allocation methods needs to be replaced with a sentinel to canonicalize is to the empty function object. R=bmeurer@chromium.org TEST=mjsunit/regress/regress-4169 BUG=v8:4169 LOG=N Committed: https://crrev.com/eb0593e1376f84bc058406ee0ca387d98858ba9d Cr-Commit-Position: refs/heads/master@{#28888}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -11 lines) Patch
M src/compiler/ast-graph-builder.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 5 chunks +21 lines, -6 lines 0 comments Download
A + test/mjsunit/regress/regress-4169.js View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 6 months ago (2015-06-09 13:11:12 UTC) #1
Benedikt Meurer
LGTM.
5 years, 6 months ago (2015-06-10 04:44:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1172013002/1
5 years, 6 months ago (2015-06-10 06:01:55 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-10 06:03:08 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 06:03:23 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb0593e1376f84bc058406ee0ca387d98858ba9d
Cr-Commit-Position: refs/heads/master@{#28888}

Powered by Google App Engine
This is Rietveld 408576698