Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: chrome/common/crash_keys.cc

Issue 1171973004: Ensure the new navigation classifier works in the real world. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/frame_host/navigation_controller_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/crash_keys.h" 5 #include "chrome/common/crash_keys.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/format_macros.h" 8 #include "base/format_macros.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/strings/string_split.h" 10 #include "base/strings/string_split.h"
(...skipping 177 matching lines...) Expand 10 before | Expand all | Expand 10 after
188 { "rwhvm_window", kMediumSize }, 188 { "rwhvm_window", kMediumSize },
189 // media/: 189 // media/:
190 { "VideoCaptureDeviceQTKit", kSmallSize }, 190 { "VideoCaptureDeviceQTKit", kSmallSize },
191 #endif 191 #endif
192 #if defined(KASKO) 192 #if defined(KASKO)
193 { kKaskoGuid, kSmallSize }, 193 { kKaskoGuid, kSmallSize },
194 { kKaskoEquivalentGuid, kSmallSize }, 194 { kKaskoEquivalentGuid, kSmallSize },
195 #endif 195 #endif
196 { kBug464926CrashKey, kSmallSize }, 196 { kBug464926CrashKey, kSmallSize },
197 { kViewCount, kSmallSize }, 197 { kViewCount, kSmallSize },
198 // Temporary for http://crbug.com/369661.
199 { "369661-navurl", kLargeSize },
200 { "369661-oldtype", kSmallSize },
201 { "369661-newtype", kSmallSize },
202 { "369661-naventryid", kSmallSize },
203 { "369661-oldignore", kSmallSize },
204 { "369661-newignore", kSmallSize },
205 { "369661-didcreatenew", kSmallSize },
206 { "369661-pageid", kSmallSize },
207 { "369661-maxpageid", kSmallSize },
208 { "369661-earlyreturn", kSmallSize },
209 { "369661-doubleignore", kSmallSize },
210 // End http://crbug.com/369661.
198 }; 211 };
199 212
200 // This dynamic set of keys is used for sets of key value pairs when gathering 213 // This dynamic set of keys is used for sets of key value pairs when gathering
201 // a collection of data, like command line switches or extension IDs. 214 // a collection of data, like command line switches or extension IDs.
202 std::vector<base::debug::CrashKey> keys( 215 std::vector<base::debug::CrashKey> keys(
203 fixed_keys, fixed_keys + arraysize(fixed_keys)); 216 fixed_keys, fixed_keys + arraysize(fixed_keys));
204 217
205 // Register the switches. 218 // Register the switches.
206 { 219 {
207 // The fixed_keys names are string constants. Use static storage for 220 // The fixed_keys names are string constants. Use static storage for
(...skipping 233 matching lines...) Expand 10 before | Expand all | Expand 10 after
441 } 454 }
442 455
443 ScopedPrinterInfo::~ScopedPrinterInfo() { 456 ScopedPrinterInfo::~ScopedPrinterInfo() {
444 for (size_t i = 0; i < kPrinterInfoCount; ++i) { 457 for (size_t i = 0; i < kPrinterInfoCount; ++i) {
445 std::string key = base::StringPrintf(kPrinterInfo, i + 1); 458 std::string key = base::StringPrintf(kPrinterInfo, i + 1);
446 base::debug::ClearCrashKey(key); 459 base::debug::ClearCrashKey(key);
447 } 460 }
448 } 461 }
449 462
450 } // namespace crash_keys 463 } // namespace crash_keys
OLDNEW
« no previous file with comments | « no previous file | content/browser/frame_host/navigation_controller_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698