Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 1171973004: Ensure the new navigation classifier works in the real world. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
7 7
8 #include <map> 8 #include <map>
9 #include <vector> 9 #include <vector>
10 10
11 #include "base/callback.h" 11 #include "base/callback.h"
12 #include "base/compiler_specific.h" 12 #include "base/compiler_specific.h"
13 #include "base/debug/crash_logging.h"
13 #include "base/gtest_prod_util.h" 14 #include "base/gtest_prod_util.h"
14 #include "base/memory/weak_ptr.h" 15 #include "base/memory/weak_ptr.h"
15 #include "base/strings/string16.h" 16 #include "base/strings/string16.h"
17 #include "base/strings/string_number_conversions.h" // Temporary
16 #include "base/time/time.h" 18 #include "base/time/time.h"
17 #include "content/browser/accessibility/browser_accessibility_manager.h" 19 #include "content/browser/accessibility/browser_accessibility_manager.h"
18 #include "content/browser/site_instance_impl.h" 20 #include "content/browser/site_instance_impl.h"
19 #include "content/common/accessibility_mode_enums.h" 21 #include "content/common/accessibility_mode_enums.h"
20 #include "content/common/content_export.h" 22 #include "content/common/content_export.h"
21 #include "content/common/frame_message_enums.h" 23 #include "content/common/frame_message_enums.h"
22 #include "content/common/frame_replication_state.h" 24 #include "content/common/frame_replication_state.h"
23 #include "content/common/mojo/service_registry_impl.h" 25 #include "content/common/mojo/service_registry_impl.h"
24 #include "content/common/navigation_params.h" 26 #include "content/common/navigation_params.h"
25 #include "content/public/browser/render_frame_host.h" 27 #include "content/public/browser/render_frame_host.h"
(...skipping 406 matching lines...) Expand 10 before | Expand all | Expand 10 after
432 434
433 // Tears down the browser-side state relating to the Mojo connection between 435 // Tears down the browser-side state relating to the Mojo connection between
434 // this instance and its associated render frame. 436 // this instance and its associated render frame.
435 void InvalidateMojoConnection(); 437 void InvalidateMojoConnection();
436 438
437 // Returns whether the frame is focused. A frame is considered focused when it 439 // Returns whether the frame is focused. A frame is considered focused when it
438 // is the parent chain of the focused frame within the frame tree. In 440 // is the parent chain of the focused frame within the frame tree. In
439 // addition, its associated RenderWidgetHost has to be focused. 441 // addition, its associated RenderWidgetHost has to be focused.
440 bool IsFocused(); 442 bool IsFocused();
441 443
444 // Temporary for http://crbug.com/369661
Charlie Reis 2015/06/09 23:32:13 nit: End comment with period (here and elsewhere).
Avi (use Gerrit) 2015/06/10 16:34:53 Done.
445 std::string CommitCountString();
446
442 protected: 447 protected:
443 friend class RenderFrameHostFactory; 448 friend class RenderFrameHostFactory;
444 449
445 // |flags| is a combination of CreateRenderFrameFlags. 450 // |flags| is a combination of CreateRenderFrameFlags.
446 // TODO(nasko): Remove dependency on RenderViewHost here. RenderProcessHost 451 // TODO(nasko): Remove dependency on RenderViewHost here. RenderProcessHost
447 // should be the abstraction needed here, but we need RenderViewHost to pass 452 // should be the abstraction needed here, but we need RenderViewHost to pass
448 // into WebContentsObserver::FrameDetached for now. 453 // into WebContentsObserver::FrameDetached for now.
449 RenderFrameHostImpl(SiteInstance* site_instance, 454 RenderFrameHostImpl(SiteInstance* site_instance,
450 RenderViewHostImpl* render_view_host, 455 RenderViewHostImpl* render_view_host,
451 RenderFrameHostDelegate* delegate, 456 RenderFrameHostDelegate* delegate,
(...skipping 269 matching lines...) Expand 10 before | Expand all | Expand 10 after
721 // PlzNavigate: Owns the stream used in navigations to store the body of the 726 // PlzNavigate: Owns the stream used in navigations to store the body of the
722 // response once it has started. 727 // response once it has started.
723 scoped_ptr<StreamHandle> stream_handle_; 728 scoped_ptr<StreamHandle> stream_handle_;
724 729
725 // Context shared for each PermissionService instance created for this RFH. 730 // Context shared for each PermissionService instance created for this RFH.
726 scoped_ptr<PermissionServiceContext> permission_service_context_; 731 scoped_ptr<PermissionServiceContext> permission_service_context_;
727 732
728 // The frame's Mojo Shell service. 733 // The frame's Mojo Shell service.
729 scoped_ptr<FrameMojoShell> frame_mojo_shell_; 734 scoped_ptr<FrameMojoShell> frame_mojo_shell_;
730 735
736 // Temporary for http://crbug.com/369661
737 int commit_count_ = 0;
Charlie Reis 2015/06/09 23:32:13 *shakes fist at C++11* I'm not sure what language
Avi (use Gerrit) 2015/06/10 16:34:53 Hahahaha
738
731 // NOTE: This must be the last member. 739 // NOTE: This must be the last member.
732 base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_; 740 base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_;
733 741
734 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl); 742 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl);
735 }; 743 };
736 744
737 } // namespace content 745 } // namespace content
738 746
739 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 747 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698