Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: media/audio/audio_output_ipc.h

Issue 1171953002: Add IPC interface for switching the audio output device for a given audio stream in the browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address reviewers' comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/audio_output_ipc.h
diff --git a/media/audio/audio_output_ipc.h b/media/audio/audio_output_ipc.h
index f85d8e0195325dfc3add33238bc77d56a9d85cc2..05032525e6ce1f32e2c8259bc4cf52354765eba9 100644
--- a/media/audio/audio_output_ipc.h
+++ b/media/audio/audio_output_ipc.h
@@ -5,10 +5,13 @@
#ifndef MEDIA_AUDIO_AUDIO_OUTPUT_IPC_H_
#define MEDIA_AUDIO_AUDIO_OUTPUT_IPC_H_
+#include <string>
+
#include "base/memory/shared_memory.h"
#include "base/sync_socket.h"
#include "media/audio/audio_parameters.h"
#include "media/base/media_export.h"
+#include "url/gurl.h"
namespace media {
@@ -27,6 +30,16 @@ class MEDIA_EXPORT AudioOutputIPCDelegate {
kStateLast = kError
};
+ // Result of an audio output device switch operation
+ enum SwitchOutputDeviceResult {
+ kSuccess = 0,
+ kNotFoundError,
+ kSecurityError,
+ kObsoleteError,
+ kNotSupportedError,
+ kSwitchOutputDeviceResultLast = kNotSupportedError
ncarter (slow) 2015/06/10 18:10:48 "Though the Google C++ Style Guide now says to use
ncarter (slow) 2015/06/10 18:13:03 Also: "enum values should start with the name of t
Guido Urdaneta 2015/06/10 18:23:05 I'm using kStyle here because the file contains a
ncarter (slow) 2015/06/10 19:14:20 Tell you what: if you do 3, I'll send you a patch
Guido Urdaneta 2015/06/11 00:51:57 Done.
+ };
+
// Called when state of an audio stream has changed.
virtual void OnStateChanged(State state) = 0;

Powered by Google App Engine
This is Rietveld 408576698