Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1171943003: [turbofan] Make Runtime::kSetProperty have a frame state. (Closed)

Created:
5 years, 6 months ago by Michael Starzinger
Modified:
5 years, 6 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Make Runtime::kSetProperty have a frame state. R=jarin@chromium.org TEST=cctest/test-api/AccessCheckThrows Committed: https://crrev.com/ce0922bc00f971f8785e4ce2dc2b2629257bfa13 Cr-Commit-Position: refs/heads/master@{#28859}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/linkage.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
5 years, 6 months ago (2015-06-09 10:47:10 UTC) #1
Benedikt Meurer
lgtm
5 years, 6 months ago (2015-06-09 11:00:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1171943003/1
5 years, 6 months ago (2015-06-09 11:01:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-09 11:11:40 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 11:11:53 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce0922bc00f971f8785e4ce2dc2b2629257bfa13
Cr-Commit-Position: refs/heads/master@{#28859}

Powered by Google App Engine
This is Rietveld 408576698