Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(166)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1171893005: DevTools: unify theming for checkbox components. (Closed)

Created:
4 years, 10 months ago by pfeldman
Modified:
4 years, 10 months ago
Reviewers:
dgozman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: unify theming for checkbox components. BUG=498100 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196785

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -50 lines) Patch
M Source/devtools/front_end/emulation/ResponsiveDesignView.js View 2 chunks +14 lines, -1 line 0 comments Download
M Source/devtools/front_end/emulation/responsiveDesignView.css View 2 chunks +0 lines, -36 lines 0 comments Download
M Source/devtools/front_end/ui/UIUtils.js View 4 chunks +18 lines, -6 lines 1 comment Download
M Source/devtools/front_end/ui/checkboxTextLabel.css View 1 chunk +32 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
pfeldman
4 years, 10 months ago (2015-06-09 15:31:04 UTC) #2
dgozman
lgtm https://codereview.chromium.org/1171893005/diff/1/Source/devtools/front_end/ui/UIUtils.js File Source/devtools/front_end/ui/UIUtils.js (right): https://codereview.chromium.org/1171893005/diff/1/Source/devtools/front_end/ui/UIUtils.js#newcode1376 Source/devtools/front_end/ui/UIUtils.js:1376: this._root.appendChild(stylesheet); Should we remove previous one, if any?
4 years, 10 months ago (2015-06-09 15:42:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1171893005/1
4 years, 10 months ago (2015-06-09 15:46:44 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2015-06-09 17:16:12 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196785

Powered by Google App Engine
This is Rietveld 408576698