Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(123)

Issue 1171893004: bindings: Supports serializer for PerformanceTiming. (Closed)

Created:
4 years, 10 months ago by Yuki
Modified:
4 years, 10 months ago
Reviewers:
haraken, tkent, bashi
CC:
blink-reviews, vivekg, arv+blink, Inactive, vivekg_samsung
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

bindings: Supports serializer for PerformanceTiming. Although the spec doesn't have a serializer in PerformanceTiming, Chrome (til M42) and IE supported a serializer and FF followed them. Considering the nature of PerformanceTiming, it's quite natural to have a serializer. Let's support JSON.stringify (again) for PerformanceTiming. BUG=497900 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196854

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Fixed layout tests. #

Patch Set 4 : Added a test for PerformanceTiming's serializer. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -1 line) Patch
M LayoutTests/fast/dom/Window/window-properties-performance.html View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/Window/window-properties-performance-expected.txt View 1 2 3 1 chunk +23 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/webtiming-document-open-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/webtiming-navigate-within-document-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/http/tests/misc/webtiming-cross-origin-and-back-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/http/tests/misc/webtiming-cross-origin-redirect-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/http/tests/misc/webtiming-no-origin-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/timing/PerformanceTiming.h View 2 chunks +4 lines, -0 lines 0 comments Download
M Source/core/timing/PerformanceTiming.cpp View 2 chunks +29 lines, -0 lines 0 comments Download
M Source/core/timing/PerformanceTiming.idl View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Yuki
Could you guys review this CL? Just FYI, here is a discussion at Mozilla. https://bugzilla.mozilla.org/show_bug.cgi?id=760851
4 years, 10 months ago (2015-06-09 12:43:48 UTC) #2
haraken
On 2015/06/09 12:43:48, Yuki wrote: > Could you guys review this CL? > > Just ...
4 years, 10 months ago (2015-06-09 12:57:25 UTC) #3
Yuki
On 2015/06/09 12:57:25, haraken wrote: > On 2015/06/09 12:43:48, Yuki wrote: > > Could you ...
4 years, 10 months ago (2015-06-10 08:07:03 UTC) #4
haraken
LGTM +tkent-san for API's owner review.
4 years, 10 months ago (2015-06-10 08:17:23 UTC) #6
tkent
lgtm
4 years, 10 months ago (2015-06-10 08:20:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1171893004/60001
4 years, 10 months ago (2015-06-10 08:21:28 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2015-06-10 10:03:45 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196854

Powered by Google App Engine
This is Rietveld 408576698