Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 1171853002: Remove WebPopupMenu, WebPopupTypeSelect, and WebPopupTypeSuggestion. (Closed)

Created:
5 years, 6 months ago by tkent
Modified:
5 years, 6 months ago
Reviewers:
keishi
CC:
blink-reviews, dglazkov+blink
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove WebPopupMenu, WebPopupTypeSelect, and WebPopupTypeSuggestion. They are unused now. This CL has no behavior changes. BUG=482686 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196737

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -53 lines) Patch
D public/web/WebPopupMenu.h View 1 chunk +0 lines, -49 lines 0 comments Download
M public/web/WebPopupType.h View 1 chunk +0 lines, -2 lines 0 comments Download
M public/web/WebViewClient.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tkent
Keishi, please review this.
5 years, 6 months ago (2015-06-09 01:18:02 UTC) #2
keishi
lgtm
5 years, 6 months ago (2015-06-09 05:22:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1171853002/1
5 years, 6 months ago (2015-06-09 05:27:31 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 05:31:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196737

Powered by Google App Engine
This is Rietveld 408576698