Load on demand

Load on demand

This fixes ordering issues.

R=jmesserly@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/4bd449fcfe45628db7e3b0a0601c6cec0e66a55e

[vsm, 2015-06-09 00:11:35]

vsm@google.com changed reviewers:
+ jmesserly@google.com

[Jennifer Messerly, 2015-06-09 14:51:52]

few minor suggestions, but LGTM overall

https://codereview.chromium.org/1171843002/diff/1/lib/runtime/dart_runtime.js
File lib/runtime/dart_runtime.js (right):

https://codereview.chromium.org/1171843002/diff/1/lib/runtime/dart_runtime.js...
lib/runtime/dart_runtime.js:5: var dart, _js_helper, _js_primitives, dartx;
_js_helper, _js_primitives could be removed here?

https://codereview.chromium.org/1171843002/diff/1/lib/runtime/dart_runtime.js...
lib/runtime/dart_runtime.js:12: dart.globalState = null;
initialize this down in bootstrap?

https://codereview.chromium.org/1171843002/diff/1/lib/runtime/dart_runtime.js...
lib/runtime/dart_runtime.js:1336: var lib = libraries[name];
let?

https://codereview.chromium.org/1171843002/diff/1/lib/runtime/dart_runtime.js...
lib/runtime/dart_runtime.js:1356: var args = this.loadImports(pendingSet);
here too

https://codereview.chromium.org/1171843002/diff/1/lib/runtime/dart_runtime.js...
lib/runtime/dart_runtime.js:1386: libraries[name] = new LibraryLoader(name,
defaultValue, imports, lazyImports, loader);
long line

https://codereview.chromium.org/1171843002/diff/1/lib/runtime/dart_runtime.js...
lib/runtime/dart_runtime.js:1394: return library;
very minor, but, the webstorm editor has a hint for this pattern that the
variable is unnecessary when immediately returned. so i've been trying to clean
those up as I go.

https://codereview.chromium.org/1171843002/diff/1/lib/runtime/dart_runtime.js...
lib/runtime/dart_runtime.js:1405: var core;
I think these could be `let` too?
Main benefit of `let` is sane(r) scoping rules.

Not that it makes a huge difference for things at function-scope level, though:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/let

basically I don't think there's any reason to use `var` anymore, except at the
top level (like we do for `dart` and `dartx`

[vsm, 2015-06-09 15:05:15]

Address comments

[vsm, 2015-06-09 15:06:06]

Committed patchset #2 (id:20001) manually as
4bd449fcfe45628db7e3b0a0601c6cec0e66a55e (presubmit successful).