Android FRE: A New Deal

Android FRE: A New Deal

Simplified as follows:
- If '--disable-fre' -- skip temporarily
- If a device hasn't been provisioned yet -- skip temporarily
- If FRE has already been completed -- great
- Otherwise, we start the FRE activity to see what to show.

Note that it doesn't matter how exactly Chrome was launched
(say, via the shortcut or via a VIEW intent), it always shows
the full FRE unless it's a test or the Setup Wizard environment.

BUG=450423
Committed: https://crrev.com/7a009eef84baa72003378bf1e4135e850ca1d708
Cr-Commit-Position: refs/heads/master@{#333612}

[aruslan, 2015-06-09 02:27:15]

The CQ bit was checked by aruslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-09 02:27:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1171833004/1

[aruslan, 2015-06-09 02:33:45]

aruslan@chromium.org changed reviewers:
+ aurimas@chromium.org

[aruslan, 2015-06-09 02:33:46]

Aurimas PTAL thanks!

https://codereview.chromium.org/1171833004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunFlowSequencer.java
(left):

https://codereview.chromium.org/1171833004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunFlowSequencer.java:168:
} else {
This "else" could never happen.

https://codereview.chromium.org/1171833004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunFlowSequencer.java
(right):

https://codereview.chromium.org/1171833004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunFlowSequencer.java:110:
if (FirstRunStatus.getFirstRunFlowComplete(mActivity)) {
Note that this check is mutually exclusive with the one below on 133.
I guess it became like this during the Second FRE Simplification (when the promo
pages were removed).

https://codereview.chromium.org/1171833004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunFlowSequencer.java:133:
// In the full FRE we always show the Welcome page, except on EDU devices.
(See above -- no changes here, just indentation.)

https://codereview.chromium.org/1171833004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunFlowSequencer.java:205:
if (!ApiCompatibilityUtils.isDeviceProvisioned(activity)) return null;
This is a new check to make sure we don't show the FRE during the Android Setup
Wizard (it uses Chrome instead of WebView because it is more fun that way).

[commit-bot: I haz the power, 2015-06-09 03:01:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-09 03:01:38]

Dry run: This issue passed the CQ dry run.

[aruslan, 2015-06-09 03:07:33]

(cc:ing FYI people)

[aurimas (slooooooooow), 2015-06-09 18:05:54]

lgtm

https://chromiumcodereview.appspot.com/1171833004/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunFlowSequencer.java
(right):

https://chromiumcodereview.appspot.com/1171833004/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunFlowSequencer.java:205:
if (!ApiCompatibilityUtils.isDeviceProvisioned(activity)) return null;
On 2015/06/09 at 02:33:46, aruslan wrote:
> This is a new check to make sure we don't show the FRE during the Android
Setup Wizard (it uses Chrome instead of WebView because it is more fun that
way).

WUT? 😭

[aruslan, 2015-06-09 22:41:14]

The CQ bit was checked by aruslan@chromium.org

[aruslan, 2015-06-09 22:41:14]

The patchset sent to the CQ was uploaded after l-g-t-m from aurimas@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1171833004/#ps20001
(title: "Rebase.")

[commit-bot: I haz the power, 2015-06-09 22:41:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1171833004/20001

[commit-bot: I haz the power, 2015-06-09 23:51:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-06-09 23:53:17]

Patchset 2 (id:??) landed as
https://crrev.com/7a009eef84baa72003378bf1e4135e850ca1d708
Cr-Commit-Position: refs/heads/master@{#333612}

[aruslan, 2015-06-10 23:08:22]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1175133002/ by aruslan@chromium.org.

The reason for reverting is: People changed their minds. See
http://crbug.com/450423#c13.