Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1171803003: [Telemetry] Copy perf_result_data_type.py & perf_tests_results_helper.py to telemetry/util (Closed)

Created:
5 years, 6 months ago by nednguyen
Modified:
5 years, 6 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Copy perf_result_data_type.py & perf_tests_results_helper.py to telemetry/util Move perf_tests_helper.py to telemetry/util/perf_tests_helper.py BUG=497905 Committed: https://crrev.com/13d4890318c7845e534fd5b786051b50b973c603 Cr-Commit-Position: refs/heads/master@{#333664}

Patch Set 1 : #

Total comments: 6

Patch Set 2 : Address Kari's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -42 lines) Patch
M tools/telemetry/telemetry/TELEMETRY_DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
D tools/telemetry/telemetry/perf_tests_helper.py View 1 chunk +0 lines, -20 lines 0 comments Download
M tools/telemetry/telemetry/results/buildbot_output_formatter.py View 1 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/util/perf_result_data_type.py View 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/util/perf_tests_helper.py View 1 chunk +1 line, -7 lines 0 comments Download
A + tools/telemetry/telemetry/util/perf_tests_results_helper.py View 1 chunk +1 line, -2 lines 0 comments Download
M tools/telemetry/telemetry/value/histogram.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/rendering_stats_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/smoothness.py View 1 7 chunks +12 lines, -7 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
nednguyen
5 years, 6 months ago (2015-06-08 23:37:24 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1171803003/20001
5 years, 6 months ago (2015-06-09 00:27:51 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/4325)
5 years, 6 months ago (2015-06-09 02:13:45 UTC) #7
nednguyen
5 years, 6 months ago (2015-06-09 15:12:58 UTC) #9
nednguyen
On 2015/06/09 15:12:58, nednguyen wrote: Ping
5 years, 6 months ago (2015-06-10 00:17:28 UTC) #10
aiolos (Not reviewing)
nits + lgtm https://codereview.chromium.org/1171803003/diff/20001/tools/telemetry/telemetry/results/buildbot_output_formatter.py File tools/telemetry/telemetry/results/buildbot_output_formatter.py (right): https://codereview.chromium.org/1171803003/diff/20001/tools/telemetry/telemetry/results/buildbot_output_formatter.py#newcode5 tools/telemetry/telemetry/results/buildbot_output_formatter.py:5: from telemetry import value as value_module ...
5 years, 6 months ago (2015-06-10 00:34:40 UTC) #11
nednguyen
https://codereview.chromium.org/1171803003/diff/20001/tools/telemetry/telemetry/results/buildbot_output_formatter.py File tools/telemetry/telemetry/results/buildbot_output_formatter.py (right): https://codereview.chromium.org/1171803003/diff/20001/tools/telemetry/telemetry/results/buildbot_output_formatter.py#newcode5 tools/telemetry/telemetry/results/buildbot_output_formatter.py:5: from telemetry import value as value_module On 2015/06/10 00:34:40, ...
5 years, 6 months ago (2015-06-10 01:18:47 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1171803003/40001
5 years, 6 months ago (2015-06-10 01:20:19 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 6 months ago (2015-06-10 02:50:04 UTC) #16
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 02:51:04 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/13d4890318c7845e534fd5b786051b50b973c603
Cr-Commit-Position: refs/heads/master@{#333664}

Powered by Google App Engine
This is Rietveld 408576698