Issue 1171783003: Revert of Update internal screen orientation headers and remove temporary redirects.

Issue 1171783003: Revert of Update internal screen orientation headers and remove temporary redirects. (Closed)

Created:
4 years, 10 months ago by tkent

Modified:
4 years, 10 months ago

Reviewers:
jochen (gone - plz use gerrit), mlamouri (slow - plz ping)

CC:
blink-reviews, dglazkov+blink

Base URL:
https://chromium.googlesource.com/chromium/blink.git@move_screen_orientation_public

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Revert of Update internal screen orientation headers and remove temporary redirects. (patchset #2 id:20001 of https://codereview.chromium.org/1165753006/) Reason for revert: Broke Android build. http://build.chromium.org/p/chromium.webkit/builders/Android%20Builder%20%28dbg%29/builds/46010 Original issue's description: > Update internal screen orientation headers and remove temporary redirects. > > This is part of a suite of three CLs: > 1. https://codereview.chromium.org/1164753002 > 2. https://codereview.chromium.org/1151373005 > 3. <this> > > BUG=453032 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196717 TBR=jochen@chromium.org,mlamouri@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=453032 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196723

Created: 4 years, 10 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+53 lines, -9 lines)			Patch
M	Source/modules/screen_orientation/LockOrientationCallback.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/modules/screen_orientation/ScreenOrientation.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/modules/screen_orientation/ScreenOrientation.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/modules/screen_orientation/ScreenOrientationController.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/modules/screen_orientation/ScreenOrientationController.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
A	public/platform/WebLockOrientationCallback.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
A	public/platform/WebLockOrientationError.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	public/platform/WebScreenInfo.h	View	1 chunk	+1 line, -1 line	0 comments	Download
A	public/platform/WebScreenOrientationClient.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
A	public/platform/WebScreenOrientationLockType.h	View	1 chunk	+24 lines, -0 lines	0 comments	Download
A	public/platform/WebScreenOrientationType.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

tkent

Created Revert of Update internal screen orientation headers and remove temporary redirects.

4 years, 10 months ago (2015-06-09 02:33:49 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1171783003/1

4 years, 10 months ago (2015-06-09 02:34:44 UTC) #2

commit-bot: I haz the power

4 years, 10 months ago (2015-06-09 02:35:51 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196723