Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(13)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1171753002: DevTools console context defaults to the Service Worker, should not. (Closed)

Created:
4 years, 10 months ago by pfeldman
Modified:
4 years, 10 months ago
Reviewers:
dgozman, sergeyv
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools console context defaults to the Service Worker, should not. BUG=497721 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196800

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -27 lines) Patch
A LayoutTests/inspector/sources/debugger-ui/last-execution-context.html View 1 1 chunk +56 lines, -0 lines 0 comments Download
A LayoutTests/inspector/sources/debugger-ui/last-execution-context-expected.txt View 1 1 chunk +16 lines, -0 lines 0 comments Download
M Source/devtools/front_end/components/ExecutionContextSelector.js View 1 2 9 chunks +48 lines, -26 lines 0 comments Download
M Source/devtools/front_end/main/Main.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
pfeldman
4 years, 10 months ago (2015-06-09 16:39:38 UTC) #2
sergeyv
lgtm
4 years, 10 months ago (2015-06-09 16:51:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1171753002/40001
4 years, 10 months ago (2015-06-09 18:43:01 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2015-06-09 21:06:21 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196800

Powered by Google App Engine
This is Rietveld 408576698