Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1171703002: Don't let anonymous boxes impede percentage resolution on children. (Closed)

Created:
5 years, 6 months ago by mstensho (USE GERRIT)
Modified:
5 years, 6 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Don't let anonymous boxes impede percentage resolution on children. We already had code in place to do this for certain anonymous box types, most prominently multicol flow threads. But no type of anonymous box should really mess up percentage resolution on children. It's just wrong, and in this case it even caused assertion failures, because anonymous ruby run boxes could end up being marked as percentage height parents. Since what child belongs inside what ruby run may change depending on where the ruby texts are inserted, and we have no code to adjust the percentage height map when percentage height children get moved from one ruby run to another (and so far there's nothing that suggests that we really need it either), let's just avoid the whole problem by skipping ruby runs when resolving percentage heights - with the bonus effect that percentage-height children of ruby elements actually get rendered properly. Some cleanup was natural at the same time, since we now bail early for any type of anonymous box in skipContainingBlockForPercentHeightCalculation(). BUG=490722 R=leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196713

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -9 lines) Patch
A LayoutTests/fast/ruby/percentage-height-child.html View 1 chunk +5 lines, -0 lines 0 comments Download
A LayoutTests/fast/ruby/percentage-height-child-crash.html View 1 chunk +14 lines, -0 lines 0 comments Download
A + LayoutTests/fast/ruby/percentage-height-child-crash-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
A LayoutTests/fast/ruby/percentage-height-child-expected.html View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutBox.cpp View 1 chunk +6 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
mstensho (USE GERRIT)
5 years, 6 months ago (2015-06-08 22:43:57 UTC) #1
leviw_travelin_and_unemployed
A patch with a *bonus* effect!? LGTM! :)
5 years, 6 months ago (2015-06-08 22:47:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1171703002/1
5 years, 6 months ago (2015-06-08 22:47:45 UTC) #4
commit-bot: I haz the power
5 years, 6 months ago (2015-06-08 23:45:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196713

Powered by Google App Engine
This is Rietveld 408576698